Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yaml.safe_load is slow as hell #3056

Merged

Conversation

VladimirFilonov
Copy link
Contributor

Closes #3055

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 19, 2025
Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2025 7:58am

@VladimirFilonov VladimirFilonov changed the title yaml.safe_load is slow as hell fix: yaml.safe_load is slow as hell Jan 19, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 34.69388% with 32 lines in your changes missing coverage. Please review.

Project coverage is 43.09%. Comparing base (e8cbcb3) to head (e212269).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/routes/workflows.py 11.11% 8 Missing ⚠️
keep/workflowmanager/workflowstore.py 22.22% 7 Missing ⚠️
keep/parser/parser.py 14.28% 6 Missing ⚠️
keep/api/models/workflow.py 40.00% 3 Missing ⚠️
keep/actions/actions_factory.py 33.33% 2 Missing ⚠️
keep/api/routes/actions.py 33.33% 2 Missing ⚠️
keep/functions/cyaml.py 80.00% 2 Missing ⚠️
tests/test_parser.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
+ Coverage   43.06%   43.09%   +0.02%     
==========================================
  Files         166      167       +1     
  Lines       16685    16696      +11     
==========================================
+ Hits         7186     7195       +9     
- Misses       9499     9501       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VladimirFilonov VladimirFilonov merged commit 2a453f0 into main Jan 19, 2025
14 of 15 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/3055-bug-get-workflow-list-endpoint-is-very-slow branch January 19, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: get workflow list endpoint is very slow
2 participants