Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): validate oauth provider scopes #974

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

talboren
Copy link
Member

No description provided.

@talboren talboren linked an issue Mar 18, 2024 that may be closed by this pull request
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 4:27pm

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.60%. Comparing base (5f5bb6f) to head (afdd475).

❗ Current head afdd475 differs from pull request most recent head 0620f34. Consider uploading reports for the commit 0620f34 to get more accurate results

Files Patch % Lines
keep/api/routes/providers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   57.64%   57.60%   -0.05%     
==========================================
  Files          87       87              
  Lines        5811     5795      -16     
==========================================
- Hits         3350     3338      -12     
+ Misses       2461     2457       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren merged commit 0ba3898 into main Mar 18, 2024
7 of 8 checks passed
@talboren talboren deleted the 961-oauth-providers-does-not-validate-scopes branch March 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth providers does not validate scopes
1 participant