Map country areas #484

lukestanley · 2024-07-22T15:05:34Z

Makes Map block able to accept a "country" property in the array of map points it processes, that show as an area, the values must be 3 letter ISO country codes.
Shading for area can be adjusted.
Custom map pin points may be set to an emoji flag.
Documentation has been updated.
A unit tests file for the block was added.

This should meet requirements for: #483

vercel · 2024-07-22T15:05:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kendraio-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2024 5:35pm

gsambrotta

Nice work and very well documented. Thank you for this, Luke.
Some minor comments here

gsambrotta · 2024-07-23T13:32:28Z

docs/workflow/blocks/map.rst

+The Map block expects incoming data to be an array of objects.
+Each object represents a marker, and/or a country area. Each object can include the following properties:
+
+- **Location-based Pin:** Provide both ``lat`` and ``long`` properties to display a pin at the specified coordinates.


Can you please write the properties exactly as they are in the object? We do like this in all the other blocks and common way of documenting.
So in this case it would be:
customPin: explanation
lat
long
label
and so on.

An example made by you ;) here: https://github.com/kendraio/kendraio-app/pull/477/files#diff-4354ba88bbed0d8a4f177a6a9a4523155e8e57b2af6e29029d98396e6f5fc8fdR20

gsambrotta · 2024-07-23T13:35:47Z

docs/workflow/blocks/map.rst

+
+Optionally, include a ``label`` property for the popup label and a ``customPin`` property for custom icons (see below).
+
+**Example: Displaying location pins**


Can we keep the format of "Examples" as chapter title and then the examples name as subtitle?
Like we do here: https://kendraio-app.readthedocs.io/en/latest/workflow/blocks/actions.html

gsambrotta · 2024-07-23T13:38:32Z

docs/workflow/blocks/map.rst

-                    "type": "mapping",
-                    "mapping": "data[?recovered > `20`].{ lat: lat, long: long, label: join(' ', [to_string(recovered), 'recovered in', combinedKey][? @ != null]) }"
-                }
+        {


This is not clear to me. Where this countryStyle object should stay? Is another property of the object containing the country, the lat and long? Or where it stays?

gsambrotta · 2024-07-23T13:40:58Z

docs/workflow/blocks/map.rst


-Example map block configuration:
+**Example: Displaying country areas**


I would suggest getting rid of this title and the countryStyle code and directly write the complete code example.

I would say you can even write an example with the customPin. Is clear enough, I don't think it needs two separate example for it.

gsambrotta · 2024-07-23T13:44:27Z

docs/workflow/blocks/map.rst

+
+**Example: Custom pin icons with emojis**
+
+This example uses emojis as custom pin icons for specific locations:


I am confuse, I don't see any difference between this customPinvalue and previous example customPin value

gsambrotta · 2024-07-23T13:46:06Z

src/app/blocks/map-block/map-block.component.spec.ts

+    component = fixture.componentInstance;
+  });
+
+  it("should create", () => {


it should create... what? :)

gsambrotta · 2024-07-23T13:52:06Z

src/app/blocks/map-block/map-block.component.spec.ts

+        lat: `51.5074`,
+        long: `-0.1278`,
+        label: "London",
+        customPin: "📍",


shouldn't this be plain text?

gsambrotta · 2024-07-23T13:54:25Z

src/app/blocks/map-block/map-block.component.ts

@@ -28,23 +29,92 @@ contributors, <a href="https://creativecommons.org/licenses/by-sa/2.0/">CC-BY-SA
  markerClusterData = [];
  markerClusterOptions = {};

+  // Country GeoJSON provider base URL
+  countryProviderBaseURL = 'https://raw.githubusercontent.com/AshKyd/geojson-regions/main/public/countries/50m/';


These are static values, right?
Can you please write them in uppercase and outside the component? So they do not get re-render/re-computed

gsambrotta · 2024-07-23T13:57:06Z

src/app/blocks/map-block/map-block.component.ts

+
+  // In-memory cache for country GeoJSON data
+  countryCache: { [key: string]: any } = {};
+
  onConfigUpdate(config: any) {
    this.height = get(config, 'height', 500);
    set(this.options, 'zoom', get(config, 'zoom', 8));
    const latln = get(config, 'latlng', [51.505, -0.09]);


Where do these static values come from? 500, 8 and [51,505, -0,09] Would be great to know. Maybe add a comment on the code?

gsambrotta · 2024-07-23T15:21:55Z

src/app/blocks/map-block/map-block.component.ts

+          });
+        }
+
+        if (lat && long) {


Is it reasonable to create an object without LAT and LONG? Aren't they indispensable information to work with a map?

A country is an area, and so is a LAT and LONG, it is just smaller, as a point.

Honestly @lukestanley I do not understand this comment. Can you help me understand better what do you mean?
My question is: Can map object exist and be valid without a LAT and LONG? If yes, how come?

CodeKrakken

Very nice work!

Map country areas

88b0c5a

lukestanley added 3 commits July 22, 2024 18:31

Makes map points optional if country is used

aa00319

Updates Map block documentation

25c1bdb

Adds Map block unit tests

aca6a2c

vercel bot deployed to Preview July 22, 2024 17:35 View deployment

lukestanley marked this pull request as ready for review July 22, 2024 17:41

lukestanley requested review from gsambrotta and CodeKrakken July 22, 2024 17:41

gsambrotta requested changes Jul 23, 2024

View reviewed changes

CodeKrakken approved these changes Jul 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map country areas #484

Map country areas #484

lukestanley commented Jul 22, 2024 •

edited

Loading

vercel bot commented Jul 22, 2024 •

edited

Loading

gsambrotta left a comment

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

gsambrotta Jul 23, 2024

lukestanley Aug 6, 2024

gsambrotta Aug 15, 2024

CodeKrakken left a comment


		Optionally, include a ``label`` property for the popup label and a ``customPin`` property for custom icons (see below).

		Example: Displaying location pins


		Example map block configuration:
		Example: Displaying country areas


		Example: Custom pin icons with emojis

		This example uses emojis as custom pin icons for specific locations:

Map country areas #484

Are you sure you want to change the base?

Map country areas #484

Conversation

lukestanley commented Jul 22, 2024 • edited Loading

vercel bot commented Jul 22, 2024 • edited Loading

gsambrotta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeKrakken left a comment

Choose a reason for hiding this comment

lukestanley commented Jul 22, 2024 •

edited

Loading

vercel bot commented Jul 22, 2024 •

edited

Loading