Improvements to install script

[za419]

• Suppport relative music paths
• Remember that we chose a proxy instead of relying on a profile
• Use heredocs to reduce echo spam
• Add defaults to inputs where that seems suitable
• Add input validation
• Read only one character for y/n prompt
• Use fail-early to stop if we reach a bad state
• Make the script able to run regardless of working directory

[kenellorando]

I'm getting stuck in the rate limiter loop, do you see similar behavior?

[3/5] Rate Limiter Timeout
Set a rate limit timeout in integer seconds. This prevents the same listener
from requesting songs within the configured timeframe. Set to 0 to disable.
      Rate limit (0): 0
Rate limit must be an integer!
      Rate limit (0): 0
Rate limit must be an integer!
      Rate limit (0): 1
Rate limit must be an integer!
      Rate limit (0): 1

The loop only breaks when I hit return, providing no value.

[za419]

I'm getting stuck in the rate limiter loop, do you see similar behavior?

[3/5] Rate Limiter Timeout
Set a rate limit timeout in integer seconds. This prevents the same listener
from requesting songs within the configured timeframe. Set to 0 to disable.
      Rate limit (0): 0
Rate limit must be an integer!
      Rate limit (0): 0
Rate limit must be an integer!
      Rate limit (0): 1
Rate limit must be an integer!
      Rate limit (0): 1

The loop only breaks when I hit return, providing no value.

That awkward moment when you get caught assuming bash is better at regex than it actually is....

Fixed:

[za419]

features.push('Tab completion of the music path using Readline')

[kenellorando]

Nice, that looks good now. The next one is in the reverse proxy setup:

[5/5] Enable Reverse Proxy?
Do you want to enable a reverse proxy? Skip if you are broadcasting locally only
or have your own reverse proxy configured. Skip if you do not know what this means.
      [y/N]: y
Please provide the domain name you will use for Cadence UI.
      Web UI Domain: cadenceradio.com
awk: not an option: -i

We must have different versions of awk-- neither my ubuntu-based dev machine nor server installations support the -i option.

[kenellorando]

I also separately bring up another question about continuity after initial installation. Assuming that an initial ./install.sh run works, will it continue to work again? For example, in a situation where a user selects no reverse proxy initially (removing NGINX_CONFIG_SECTION), then installs again at a later time but selects a reverse proxy? Vice versa as well.

Also meant to point this out yesterday nice commit hash. I don't think I've ever seen a word spelled before.

$ git checkout za419/install-improvements
HEAD is now at deaaad8 Improvements to install script

[za419]

Nice, that looks good now. The next one is in the reverse proxy setup:

[5/5] Enable Reverse Proxy?
Do you want to enable a reverse proxy? Skip if you are broadcasting locally only
or have your own reverse proxy configured. Skip if you do not know what this means.
      [y/N]: y
Please provide the domain name you will use for Cadence UI.
      Web UI Domain: cadenceradio.com
awk: not an option: -i

We must have different versions of awk-- neither my ubuntu-based dev machine nor server installations support the -i option.

Wow! Yours must be ancient, it came out in 2013....

No, really I think it's a GNU awk-specific thing. It might work if that switched out to gawk, which as it turns out is symlinked to awk in my environment:

That said, it's an easy enough fix - I'll just read in the example and write out the real yml instead of copying and then editing in place (that's arguably better anyway...)

[za419]

I also separately bring up another question about continuity after initial installation. Assuming that an initial ./install.sh run works, will it continue to work again? For example, in a situation where a user selects no reverse proxy initially (removing NGINX_CONFIG_SECTION), then installs again at a later time but selects a reverse proxy? Vice versa as well.

No reason why it shouldn't, since it recreates the config files (including the compose yml) from scratch on each run. I did it quite a few times that way while developing this and noticed no ill effects - I also ran through the scenario you mentioned just now and it seems to work perfectly.

Also meant to point this out yesterday nice commit hash. I don't think I've ever seen a word spelled before.

$ git checkout za419/install-improvements
HEAD is now at deaaad8 Improvements to install script

Hey, I didn't even notice! Cool!

Thanks for pointing it out. I also can't remember seeing a word spelled out before (except maybe the rather simple 'bad', and definitely not counting 'a' as a word of course...)

[kenellorando]

Works flawlessly for me now. Nice work.