fix response error

kenmoh · Dec 2, 2023 · 277afc0 · 277afc0
1 parent 8fb6314
commit 277afc0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/app/schema/movie_schema.py b/app/schema/movie_schema.py
@@ -17,7 +17,7 @@ class MovieCreateSchema(BaseModel):
 class MovieResponseSchema(MovieCreateSchema):
     id: int
     cover_image_url: str
-    average_rating: float | None
+    average_rating: float
     reviews: list[ReviewResponseSchema]
 
 
@@ -26,21 +26,10 @@ class MovieResponseSchema(MovieCreateSchema):
 """ START REVIEW SCHEMA """
 
 
-# class ReviewResponseSchema(BaseModel):
-#     movie_id: int
-#     author: str
-#     comment: str
-#     rating: int | None
-
-
 class ReviewCreateSchema(BaseModel):
     author: str
     comment: str
     rating: int = Field(gt=0, le=5)
 
 
-class AverageMovieReview(BaseModel):
-    average_rating: float
-
-
 """ END REVIEW SCHEMA"""
diff --git a/app/services/movie_services.py b/app/services/movie_services.py
@@ -69,6 +69,12 @@ def get_movie(movie_id, db: session):
             status_code=status.HTTP_404_NOT_FOUND,
             detail=f"Movie with ID: {movie_id} not found!",
         )
+    if movie.reviews:
+        average_rating = sum(review.rating for review in movie.reviews) / len(movie.reviews)
+        movie.average_rating = average_rating
+    else:
+        movie.average_rating = 0.0
+
     return movie