Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : added mongodb support images #286

Merged
merged 5 commits into from
Dec 28, 2023
Merged

fix : added mongodb support images #286

merged 5 commits into from
Dec 28, 2023

Conversation

Swpn0neel
Copy link
Contributor

@Swpn0neel Swpn0neel commented Dec 18, 2023 •
edited
Loading

Pull Request Template

Description

Added the images for MongoDB support

Fixes #1221

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@Swpn0neel
fix : added mongodb support images
48dece6 
Signed-off-by: Swapnoneel Saha <[email protected]>
Arindam200
Arindam200 suggested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Arindam200 Arindam200 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swpn0neel This PR is incomplete. You have just added the images

Please add the paths to the images.

@Swpn0neel
Copy link
Contributor Author

@Swpn0neel This PR is incomplete. You have just added the images

Please add the paths to the images.

Hey @Arindam200 , I've implemented the requested changes, kindly check it now!!

image

@Shashwat79802
Copy link
Contributor

Good to go

Sonichigo
Sonichigo approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonichigo Sonichigo merged commit 092dc0f into keploy:main Dec 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonichigo Sonichigo Sonichigo approved these changes

@Shashwat79802 Shashwat79802 Shashwat79802 approved these changes

@Arindam200 Arindam200 Arindam200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs]: Images Not Displaying on MongoDB Dependencies Page
4 participants
@Swpn0neel @Shashwat79802 @Sonichigo @Arindam200