Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pad_to_aspect_ratio flag to ImageConverter #2045

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Jan 16, 2025

Add pad_to_aspect_ratio flag which can be useful in some of Vision pipelines.

@sineeli sineeli requested a review from mattdangerw January 16, 2025 23:06
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But two issue before merge..

  • formatting needs updating, pip install -U ruff and reformat
  • the new test is failing on torch, we should look into it.

@sineeli
Copy link
Collaborator Author

sineeli commented Jan 22, 2025

FIxed the torch resize: keras-team/keras#20797, issue was how they were copying the values from original image to an empty image without proper border consideration. Instead we can just concat with fill value on horizontal/vertical sides, similar to how it is done in jax and tensorflow

Skipped the test case as of now once the new release is done we can remove skip.

@sineeli sineeli requested a review from mattdangerw January 23, 2025 19:21
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor changes

@sineeli sineeli added the kokoro:force-run Runs Tests on GPU label Jan 27, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Jan 27, 2025
@sineeli sineeli requested a review from mattdangerw January 27, 2025 22:31
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@mattdangerw mattdangerw merged commit 221ea6b into keras-team:master Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants