Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MobileViT example to Keras v3 #1758

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

lpizzinidev
Copy link
Contributor

Updates the MobileViT example to use the latest Keras v3 syntax.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The code looks good.

from tensorflow import keras
import keras
from keras import layers
from keras.src.applications import imagenet_utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a private API, we should not rely on it. You could reimplement the correct_pad utility in the example, or just get rid of it entirely.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Please add the generated md and ipynb files.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 5927a68 into keras-team:master Feb 18, 2024
1 check passed
sitamgithub-MSIT pushed a commit to sitamgithub-MSIT/keras-io that referenced this pull request May 30, 2024
* Updated MobileViT example to Keras v3

* added private API implementation

* updated ipynb and md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants