-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MobileViT example to Keras v3 #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The code looks good.
examples/vision/mobilevit.py
Outdated
from tensorflow import keras | ||
import keras | ||
from keras import layers | ||
from keras.src.applications import imagenet_utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a private API, we should not rely on it. You could reimplement the correct_pad
utility in the example, or just get rid of it entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Please add the generated md
and ipynb
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
* Updated MobileViT example to Keras v3 * added private API implementation * updated ipynb and md
Updates the MobileViT example to use the latest Keras v3 syntax.