Fix image urls #1957
Merged
Fix image urls #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james77777778
requested review from
fchollet,
MarkDaoust and
pcoet
as code owners
|
Thanks @james77777778 !!! |
divyashreepathihalli
approved these changes
Oct 16, 2024
fchollet
reviewed
Oct 17, 2024
| "!!wget --user-agent=\"User-Agent: Mozilla/5.0\" -O mountain_dog_mask.png https://i.imgur.com/n3Prpj6.png" | ||
| "!pip install -Uq keras\n", | ||
| "!pip install -Uq git+https://github.com/keras-team/keras-hub.git\n", | ||
| "!wget --user-agent=\"User-Agent: Mozilla/5.0\" -O mountain_dog.png https://i.imgur.com/3AHYG9Z.png\n", |
There was a problem hiding this comment.
This way of getting images from imgur isn't too great. How about... pushing the images to the keras.io repo (in an examples/assets/ folder or something like that) and linking them from github?
There was a problem hiding this comment.
Got it. Will fix it in another PR!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the image urls are broken.
Instead of:
https://keras.io/home/hongyu/workspace/keras-io/guides/img/stable_diffusion_3_in_keras_hub/stable_diffusion_3_in_keras_hub_7_0.pngThe correct url should be:
https://keras.io/img/guides/stable_diffusion_3_in_keras_hub/stable_diffusion_3_in_keras_hub_7_0.pngThe issue might be in
autogen.pybut I'm not sure what the root cause is.CC @divyashreepathihalli
I've fixed the image urls in SAM as well.