Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Timeseries example: issue #2024 #2025

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

okbalefthanded
Copy link
Contributor

  • SSVEPFormer for classification of EEG data for Brain-Computer Interface. On branch master Your branch is up to date with 'origin/master'.

Changes to be committed:
new file: examples/timeseries/eeg_bci_ssvepformer.py

  - SSVEPFormer for classification of EEG data for Brain-Computer
	Interface.
 On branch master
 Your branch is up to date with 'origin/master'.

 Changes to be committed:
	new file:   examples/timeseries/eeg_bci_ssvepformer.py
Copy link

google-cla bot commented Jan 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some nit comments.

examples/timeseries/eeg_bci_ssvepformer.py Outdated Show resolved Hide resolved
examples/timeseries/eeg_bci_ssvepformer.py Show resolved Hide resolved
examples/timeseries/eeg_bci_ssvepformer.py Outdated Show resolved Hide resolved
examples/timeseries/eeg_bci_ssvepformer.py Outdated Show resolved Hide resolved
examples/timeseries/eeg_bci_ssvepformer.py Outdated Show resolved Hide resolved
examples/timeseries/eeg_bci_ssvepformer.py Outdated Show resolved Hide resolved
 On branch master
 Your branch is up to date with 'origin/master'.

 Changes to be committed:
	modified:   eeg_bci_ssvepformer.py
@okbalefthanded
Copy link
Contributor Author

Thanks for the PR! Left some nit comments.

Thanks for the review, I have made the necessary updates.

Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Now you can add the files generated by the add_example command.

 On branch master
 Your branch is up to date with 'origin/master'.

 Changes to be committed:
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_bci_ssvepformer_19_0.png
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_ssvepformer_dataset1_interface.jpg
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_ssvepformer_frequencypowers.png
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_ssvepformer_keras_inference_time.png
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_ssvepformer_keras_training_time.png
	new file:   examples/timeseries/img/eeg_bci_ssvepformer/eeg_ssvepformer_model.jpg
	new file:   examples/timeseries/ipynb/eeg_bci_ssvepformer.ipynb
	new file:   examples/timeseries/md/eeg_bci_ssvepformer.md
@okbalefthanded
Copy link
Contributor Author

Thanks! Now you can add the files generated by the add_example command.

Done !

@SamanehSaadat
Copy link
Member

Thanks for adding the files! Could you review the .md file to make sure it looks good? It would probably be better to clean up some of the auto-generated parts like this one:
3tDupDPJgGVoavz

 On branch master
 Your branch is up to date with 'origin/master'.

 Changes to be committed:
	modified:   examples/timeseries/md/eeg_bci_ssvepformer.md
@okbalefthanded
Copy link
Contributor Author

Thanks for adding the files! Could you review the .md file to make sure it looks good? It would probably be better to clean up some of the auto-generated parts like this one: 3tDupDPJgGVoavz

Sorry, my bad I did not review that file before pushing. I've deleted those parts.

[2] Nakanishi, M. et al. (2015) ‘A Comparison Study of Canonical Correlation Analysis
Based Methods for Detecting Steady-State Visual Evoked Potentials’, Plos One, 10(10), p.
e0140703. Available at: https://doi.org/10.1371/journal.pone.0140703
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a newline at the end here?

It's failing black right now: https://github.com/keras-team/keras-io/actions/runs/13016143246/job/36753267674?pr=2025

 On branch master
 Your branch is up to date with 'origin/master'.

 Changes to be committed:
	modified:   examples/timeseries/eeg_bci_ssvepformer.py
@hertschuh hertschuh merged commit 54c7d73 into keras-team:master Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants