Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example addition for MoE #2051

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Example addition for MoE #2051

wants to merge 5 commits into from

Conversation

damoonsh
Copy link

I am writing up a simple implementation for MoE for Dense and CNN model using the MNIST. Then at the end I will write an MoE class to support any kind of layer using simple approach. I have written parts of the code and will iteratively add.

Please let me know if there is a problem/concern with the example.

Copy link

google-cla bot commented Feb 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@damoonsh
Copy link
Author

The example is not complete yet but this is the overall structure of it.

Also I am unable to sign the CLA, it goes to 400 page:
Screenshot 2025-02-28 at 01 46 02

@divyashreepathihalli
Copy link
Contributor

Thanks @damoonsh I will take a look at this soon.

import numpy as np
import keras
from keras import layers, models
import tensorflow as tf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 2023 onwards all examples and guides added to Keras IO is Keras 3 only. Can you please update the implementation to Keras 3 - here is a guide for migration https://keras.io/guides/migrating_to_keras_3/

Copy link
Contributor

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

  • why is the vocal_track_seperation.py deleted?
  • Good to only have the .py file until PR approval - you can genrate the .ipynb and .md file after the .py is approved
  • The example implementation needs to be in Kears 3

@damoonsh
Copy link
Author

damoonsh commented Mar 3, 2025

Not sure what happened with vocal_track file, I am trying to take it out of the PR.
I took the .ipynb and .md out. And I followed the instruction for keras 3.
If the .py is approved I can make another PR without the vocal files.

@damoonsh
Copy link
Author

damoonsh commented Mar 5, 2025

@divyashreepathihalli Took the unnecessary files out, there is only the .py file now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants