Add Hard Negative Mining Layer. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hertschuh
force-pushed
the
hard_negative
branch
from
d7d1c06 to
0c9771a
Compare
abheesht17
suggested changes
Feb 22, 2025
| from keras_rs.src.layers.loss import hard_negative_mining | ||
|
|
||
|
|
||
| class HardNegativeMiningTest(testing.TestCase, parameterized.TestCase): |
There was a problem hiding this comment.
Let's add a test_predict test to check whether it works when compiled?
There was a problem hiding this comment.
Also added to FeatureCross
| match. | ||
| """ | ||
| num_row = ops.shape(data)[0] | ||
| num_column = ops.shape(data)[1] |
There was a problem hiding this comment.
Since we know it'll be a 2D tensor, we can rewrite these two lines to:
num_row, num_column = ops.shape(data)
| num_hard_negatives: How many hard negatives to return. | ||
| """ | ||
|
|
||
| def __init__(self, num_hard_negatives: int) -> None: |
There was a problem hiding this comment.
**kwargs, and then passed to super().__init__(**kwargs)
I'll be moving this layer to the |
This layer extract negative logits and labels. Also made layer test more similar.
hertschuh
force-pushed
the
hard_negative
branch
from
0c9771a to
54d34c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This layer extract negative logits and labels.