mlx - handle int64 and uint64 for scatter and cum* #19666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkarthee
commented
May 5, 2024
| @@ -211,6 +209,10 @@ def vectorized_map(function, elements): | |||
| def scatter(indices, values, shape): | |||
| indices = convert_to_tensor(indices) | |||
| values = convert_to_tensor(values) | |||
| if values.dtype == mx.int64: | |||
There was a problem hiding this comment.
Temporary fix for until scatter bug is resolved in mlx. See mlx_backend .
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mlx #19666 +/- ##
======================================
Coverage ? 75.54%
======================================
Files ? 508
Lines ? 47222
Branches ? 8686
======================================
Hits ? 35675
Misses ? 9805
Partials ? 1742
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lkarthee
changed the title
fchollet
approved these changes
May 6, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.