Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #19571
All tests in
keras/src/layers/rnn/
(excluding those with convolutions) are passing!A few notes:
mlx.numpy.flip
asslice
did not work with mlx arrays[::-1]
for simple flipping, but it failed to propagate gradients with the bidirectional rnn layersmlx.linalg.qr
as mlx's implementation only works on square matrices for now (is numpy preferred in this case?)