Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlx - more conv #20807

Merged
merged 3 commits into from
Jan 24, 2025
Merged

mlx - more conv #20807

merged 3 commits into from
Jan 24, 2025

Conversation

acsweet
Copy link

@acsweet acsweet commented Jan 24, 2025

This addresses #19571

This implements

  • nn.depthwise_conv
  • nn.separable_conv
  • nn.conv_transpose

All tests related to convolutions in keras/src/ops/nn_test.py::NNOpsCorrectnessTest are passing

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work -- thank you for the contribution

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 24, 2025
@fchollet fchollet merged commit e2e2288 into keras-team:mlx Jan 24, 2025
3 of 8 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 24, 2025
@acsweet acsweet deleted the mlx-more-conv branch February 2, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants