fix(ops): Fix ops.argmin() handling of subnormal float values in Keras backends #20812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harshaljanjani
commented
Jan 25, 2025
harshaljanjani
commented
- Update JAX and NumPy backends to handle subnormal float comparisons (TODO: Ensure TensorFlow compatibility).
- Add test case to verify subnormal float value handling.
- Addresses issue Keras argmin function returns incorrect index when handling subnormal float values. #20355.
…s backends - Update JAX and NumPy backends to handle subnormal float comparisons - Add test case to verify subnormal float value handling
|
TODO: Ensure TensorFlow compatibility. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20812 +/- ##
=======================================
Coverage 82.00% 82.01%
=======================================
Files 558 558
Lines 52170 52182 +12
Branches 8065 8067 +2
=======================================
+ Hits 42783 42795 +12
Misses 7421 7421
Partials 1966 1966
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fchollet
approved these changes
Jan 26, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.