mlx - fix error with loading models with h5 and update mlx.core.while_loop
#20819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jan 28, 2025
keras/src/backend/mlx/core.py
Outdated
| if _is_h5py_dataset(x): | ||
| if h5py is None: | ||
| raise ImportError( | ||
| "h5py must be installed in order to load a model." |
There was a problem hiding this comment.
Technically this might be raised outside of model loading context (maybe someone is just reading some h5 data). Let's make the error message generic
fchollet
approved these changes
Jan 29, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #19571
multi_head_attention_test.py::MultiHeadAttentionTest::test_loratest was failing on loading the model.It was due to
mlx.core.array()not able to load h5py Dataset objects. Now loading it with numpy first.Does that check I added in
mlx.core.convert_to_tensorlook good?