Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlx - nn and core updates post merge #20832

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

acsweet
Copy link

@acsweet acsweet commented Jan 31, 2025

This addresses #19571

Patched and implemented missing methods in:

  • nn.py (a lot has been added since the mlx branch started!)
  • core.py
  • rnn.py (very simple scan update)

Started to adjust tests for various layers that mlx doesn't support:

  • flash_attention
  • dtypes float64, complex128

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 225 lines in your changes missing coverage. Please review.

Please upload report for BASE (mlx@168f13d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
keras/src/backend/mlx/core.py 0.00% 129 Missing ⚠️
keras/src/backend/mlx/nn.py 0.00% 93 Missing ⚠️
keras/src/backend/mlx/__init__.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             mlx   #20832   +/-   ##
======================================
  Coverage       ?   72.72%           
======================================
  Files          ?      572           
  Lines          ?    55023           
  Branches       ?     8489           
======================================
  Hits           ?    40016           
  Misses         ?    13069           
  Partials       ?     1938           
Flag Coverage Δ
keras 72.64% <0.00%> (?)
keras-jax 61.09% <0.00%> (?)
keras-numpy 56.08% <0.00%> (?)
keras-openvino 28.36% <0.00%> (?)
keras-tensorflow 61.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 31, 2025
@fchollet fchollet merged commit ce9aec7 into keras-team:mlx Jan 31, 2025
6 of 9 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants