Skip to content

Added numpy.outer function using opset14 #21213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

blue-dreaming-jay
Copy link

Modified import statement for opset14 in numpy.py (original one commented out)
Added numpy.outer function using opset14
Deleted test_outer and test_outer_ lines from excluded_concrete_tests.txt
Implementation of numpy.outer assumes that the given tensors are 1-dimensional arrays, and will likely produce bad results

Modified import statement for opset14 in numpy.py (original one commented out)
Copy link

google-cla bot commented Apr 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (37eacb0) to head (df1cda4).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 66.66% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21213      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.02%     
==========================================
  Files         564      564              
  Lines       54476    54527      +51     
  Branches     8470     8473       +3     
==========================================
+ Hits        45005    45040      +35     
- Misses       7395     7403       +8     
- Partials     2076     2084       +8     
Flag Coverage Δ
keras 82.41% <66.66%> (-0.02%) ⬇️
keras-jax 63.65% <0.00%> (-0.06%) ⬇️
keras-numpy 58.78% <0.00%> (-0.06%) ⬇️
keras-openvino 33.02% <66.66%> (+0.03%) ⬆️
keras-tensorflow 64.06% <0.00%> (-0.06%) ⬇️
keras-torch 63.72% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned requested a review from mattdangerw April 29, 2025 09:44
@gbaned gbaned added this to PR Queue Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Apr 29, 2025
@gbaned
Copy link
Collaborator

gbaned commented Apr 29, 2025

Hi @blue-dreaming-jay Can you please resolve the conflicts? Thank you.

@blue-dreaming-jay
Copy link
Author

I will resolve them. I'd like to clarify if the type that the produced tensor should be is the type produced by applying dtypes.result_type() on the dtypes of inputted tensors x1 and x2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

3 participants