-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Added numpy.outer function using opset14 #21213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Modified import statement for opset14 in numpy.py (original one commented out)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21213 +/- ##
==========================================
- Coverage 82.61% 82.60% -0.02%
==========================================
Files 564 564
Lines 54476 54527 +51
Branches 8470 8473 +3
==========================================
+ Hits 45005 45040 +35
- Misses 7395 7403 +8
- Partials 2076 2084 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
any kind of input that can be converted into a numpy array.
Hi @blue-dreaming-jay Can you please resolve the conflicts? Thank you. |
I will resolve them. I'd like to clarify if the type that the produced tensor should be is the type produced by applying dtypes.result_type() on the dtypes of inputted tensors x1 and x2? |
Modified import statement for opset14 in numpy.py (original one commented out)
Added numpy.outer function using opset14
Deleted test_outer and test_outer_ lines from excluded_concrete_tests.txt
Implementation of numpy.outer assumes that the given tensors are 1-dimensional arrays, and will likely produce bad results