implementation of logaddexp in openvino backend (issue #29489) #21216
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21216 +/- ##
==========================================
+ Coverage 82.60% 82.61% +0.01%
==========================================
Files 564 564
Lines 54404 54454 +50
Branches 8460 8467 +7
==========================================
+ Hits 44938 44986 +48
- Misses 7391 7395 +4
+ Partials 2075 2073 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| m = maximum(x1, x2) | ||
| return add(m, log(add(exp(subtract(x1, m)), exp(subtract(x2, m))))) |
There was a problem hiding this comment.
not correct implementation. See other PRs as examples
|
do NOT merge!!! |
I implemented the numpy logaddexp function in openvino backend using functions already coded in this file. The tests seem to pass, but maybe implementing logaddexp from zero without using the openvino numpy functions would be more effective. @rkazants could you review the PR ?