Skip to content

[OpenVINO Backend] Support for numpy.flip #21230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chuinzer
Copy link

This change resolves #29359. @rkazants please review this PR.
My bad for spamming PRs, had some problems with CLA.

Copy link

google-cla bot commented Apr 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chuinzer chuinzer changed the title Add numpy.flip support for OpenVINO backend. [OpenVINO Backend] Support for numpy.flip May 1, 2025
@@ -1,4 +1,5 @@
import numpy as np
import openvino.runtime.opset1 as ov1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed. use ov_opset

@gbaned gbaned added this to PR Queue May 2, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 2, 2025
chuinzer added 2 commits May 2, 2025 15:49
 Removed NumpyDtypeTest::test_flip .
Replaced with ov_opset
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (37eacb0) to head (f8ab0e0).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21230      +/-   ##
==========================================
- Coverage   82.61%   79.83%   -2.79%     
==========================================
  Files         564      564              
  Lines       54476    54520      +44     
  Branches     8470     8473       +3     
==========================================
- Hits        45005    43524    -1481     
- Misses       7395     8972    +1577     
+ Partials     2076     2024      -52     
Flag Coverage Δ
keras 79.64% <0.00%> (-2.78%) ⬇️
keras-jax 63.66% <0.00%> (-0.06%) ⬇️
keras-numpy 58.79% <0.00%> (-0.05%) ⬇️
keras-openvino ?
keras-tensorflow 64.07% <0.00%> (-0.05%) ⬇️
keras-torch 63.73% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chuinzer
Copy link
Author

chuinzer commented May 2, 2025

Looking into the error. Will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants