Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmtest: use danobi/vmtest instead of homegrown vm solution #243

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

chantra
Copy link
Contributor

@chantra chantra commented Oct 21, 2023

https://github.com/danobi/vmtest make it easy to run a VM with a given kernel
and using the host rootfs (RO) and a shared directory (RW).

This will help us with a couple of issue:

This change migrates the tests and veristat runs from using prepare-rootfs + run-qemu actions to using run-vmtest instead

https://github.com/danobi/vmtest make it easy to run a VM with a given kernel
and using the host rootfs (RO) and a shared directory (RW).

This will help us with a couple of issue:
- we don't have to maintain a rootfs anymore
- when running the test, we do not need to perform a dance with libguestfs, which allows us to save time during test, and make it trivial to exchange files between the host and the guest.
- we won't have anymore discrepency between the libraries used in the host and guest (like explained in libbpf/ci#84 and also libbpf/ci#103)

This change migrates the test runs from using `prepare-rootfs` + `run-qemu` actions to using `run-vmtest` instead.
Similar to the previous change, but for veristat

Signed-off-by: Manu Bretelle <[email protected]>
@chantra chantra marked this pull request as ready for review January 25, 2024 23:07
@chantra chantra changed the title [vmtest] using danobi/vmtest vmtest: use danobi/vmtest instead of homegrown vm solution Jan 25, 2024
@chantra
Copy link
Contributor Author

chantra commented Jan 26, 2024

Some of the testing can only be done from kernel-patches/bpf repo. This is being done in kernel-patches/bpf#6325 / https://github.com/kernel-patches/bpf/actions/runs/7661982374

@chantra chantra merged commit 6fa8559 into kernel-patches:master Jan 26, 2024
47 of 48 checks passed
@chantra chantra deleted the vmtest branch January 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant