Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer: Add HTML helper to view nodes #458

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

nuclearcat
Copy link
Member

This is PoC of API viewer for development purposes.

@nuclearcat nuclearcat marked this pull request as draft January 25, 2024 07:31
@nuclearcat nuclearcat force-pushed the add-api-viewer branch 13 times, most recently from 8dd35dc to ad73e78 Compare February 1, 2024 06:38
@nuclearcat nuclearcat force-pushed the add-api-viewer branch 5 times, most recently from b83af23 to 5b49a6e Compare February 6, 2024 11:35
@nuclearcat nuclearcat marked this pull request as ready for review February 14, 2024 09:48
@nuclearcat
Copy link
Member Author

I think we might need to merge it, unless there is objections, cause already i have new experimental updates planned for next stage

@a-wai
Copy link
Contributor

a-wai commented Feb 14, 2024

Agreed, it's already extremely helpful!

If I may request a feature for the next iteration: adding an option to download the node as raw json would be nice :)

Copy link
Contributor

@a-wai a-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the usefullness, my JS skills are basically null

This is PoC of API viewer for development purposes.

Signed-off-by: Denys Fedoryshchenko <[email protected]>
@nuclearcat
Copy link
Member Author

Merging, as i need to add few more features to it and create new PR.

@nuclearcat nuclearcat added this pull request to the merge queue Feb 20, 2024
Merged via the queue into kernelci:main with commit dcc5c94 Feb 20, 2024
4 checks passed
@nuclearcat nuclearcat deleted the add-api-viewer branch February 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants