debos: Don't remove extra_packages #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strip.sh script is passed a list of packages to remove. For very unclear reasons the list that is passed by debos is the extra_packages list but this is a list of packages we want in the shipped image, there is a separate extra_packages_remove which is intended for removal which we already handle with a separate debos step. Just remove the argument and it's handling from strip.sh, ensuring that we don't remove extra_packages. This hasn't been apparent because strip.sh only takes effect for ext4 images, we don't use those images for many platforms. That is a separate issue which should also be addressed. Signed-off-by: Mark Brown <[email protected]>
a-wai
approved these changes
Feb 21, 2024
|
Tested and built rootfs with this changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strip.sh script is passed a list of packages to remove. For very
unclear reasons the list that is passed by debos is the extra_packages
list but this is a list of packages we want in the shipped image, there
is a separate extra_packages_remove which is intended for removal which
we already handle with a separate debos step. Just remove the argument
and it's handling from strip.sh, ensuring that we don't remove
extra_packages.
This hasn't been apparent because strip.sh only takes effect for ext4
images, we don't use those images for many platforms. That is a
separate issue which should also be addressed.
Signed-off-by: Mark Brown [email protected]