Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/core: rename early-access entries #2638

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

JenySadadia
Copy link
Collaborator

Rename configurations for early-access to production. Early access instance was setup for the initial release phase. It's been used as production now.

Rename configurations for `early-access` to
`production`. Early access instance was setup
for the initial release phase. It's been used as
production now.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia JenySadadia requested a review from nuclearcat August 15, 2024 06:03
@JenySadadia JenySadadia added the staging-skip Don't test automatically on staging.kernelci.org label Aug 15, 2024
@JenySadadia JenySadadia requested a review from pawiecz August 15, 2024 06:04
@JenySadadia
Copy link
Collaborator Author

@JenySadadia JenySadadia removed the staging-skip Don't test automatically on staging.kernelci.org label Nov 19, 2024
Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch LGTM

I'd wait with merging it to e.g. next prod update on Monday to:

  1. Announce the rename on weekly community meeting
  2. Give some time to adjust client configs
  3. Replace all the early-access mentions in docs

@pawiecz
Copy link
Contributor

pawiecz commented Nov 19, 2024

@nuclearcat Should we also update this https://github.com/kernelci/kernelci-core/blob/main/config/runtime/base/kubernetes.jinja2#L58 ?

I'd go for it for consistency. It would also require changing

params['k8s_api_key'] = 'kci-api-jwt-early-access'

It could be done separately of this PR (as a next step)

@JenySadadia
Copy link
Collaborator Author

Replace all the early-access mentions in docs

Thanks for pointing this out.
Created kernelci/kernelci-project#488 and kernelci/kernelci-project#489

@nuclearcat nuclearcat added this pull request to the merge queue Nov 25, 2024
Merged via the queue into kernelci:main with commit e86fe6b Nov 25, 2024
4 checks passed
@JenySadadia JenySadadia deleted the rename-early-access-configs branch November 25, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants