Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline.yaml: Add one more lab and board #356

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

nuclearcat
Copy link
Member

As good example for future improvements and to detect bugs in corner case we can add also one more lab and device. This is also unfortunately required to add one more real hardware device, as production lab doesn't support properly Azure files (yet), and it might be also good case to improve (detect infrastructure failure).

Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @broonie also volunteered to have his lab enabled with early access.

@gctucker
Copy link
Contributor

About this particular PR, @pawiecz can confirm but the Collabora LAVA staging lab shouldn't be used for production use-cases. So while it's probably OK to have it right now, it should be removed or somehow treated differently when the new API reaches actual production status.

@nuclearcat
Copy link
Member Author

Yes, if this works we can try to enable @broonie as well. At moment i am enabling it because Azure caching fix will be deployed on production only at December, so i need something else to test on.

As good example for future improvements and to detect bugs in
corner case we can add also one more lab and device.
This is also unfortunately required to add one more real hardware
device, as production lab doesn't support properly Azure files (yet),
and it might be also good case to improve (detect infrastructure failure).

Signed-off-by: Denys Fedoryshchenko <[email protected]>
@gctucker
Copy link
Contributor

What Azure caching fix? Is this something on the Collabora LAVA lab side?

@nuclearcat
Copy link
Member Author

@gctucker
Copy link
Contributor

Right but is the fix going to be deployed in the LAVA lab or on the Azure side?

@nuclearcat
Copy link
Member Author

LAVA lab, its more workaround than fix.

@gctucker
Copy link
Contributor

OK thanks. Do you know if other labs may be impacted as well, if this is a widely used caching mechanism?

@nuclearcat
Copy link
Member Author

Yes, it is typical caching mechanism, and they might need to deploy similar workaround or we might need to change storage solution.

@gctucker
Copy link
Contributor

Right, so that's something that would be ideally addressed before making the first production deployment. I believe one possibility mentioned in the past was to use MinIO on top of Azure storage.

Is there a GitHub issue about this? There is definitely one about deciding which storage solution to use for production and which ones to support in general, but I don't remember seeing one about this particular caching problem.

@nuclearcat
Copy link
Member Author

It is mentioned since October: kernelci/kernelci-api#381

@gctucker
Copy link
Contributor

RIght, so there isn't any GitHub issue about this particular problem. Probably it would be worth creating one and resolving it before the first production deployment happens (in early January I guess).

@nuclearcat
Copy link
Member Author

381 is exactly about that, storage options. Probably i should add backend i tested recently and developed in go, as it is backward compatible with old one (means already implemented, i tested - it works), i will do that as will sort out current tasks.

@gctucker
Copy link
Contributor

Right - there just isn't an issue specifically about the fact that we can't use Azure Files with caching in LAVA. Never mind me...

@nuclearcat
Copy link
Member Author

Tested on staging and verified on dozzle

@nuclearcat nuclearcat added this pull request to the merge queue Dec 8, 2023
Merged via the queue into kernelci:main with commit efb842a Dec 8, 2023
3 checks passed
@nuclearcat nuclearcat deleted the add-lab-board branch December 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants