-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: chromeos: Add ChromiumOS tree and Clang kbuild jobs #995
Conversation
Please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume you tested the chromeos branch with Clang 17 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it could be a bit more concise but there's nothing wrong with the current implementation.
config/jobs-chromeos.yaml
Outdated
tree: | ||
- chromiumos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tree: | |
- chromiumos | |
<<: *kbuild-clang-17-arm64-chromeos-rules |
Thanks for the feedback - I'll apply the fixes as suggested. |
91422e4
to
0e8a9b9
Compare
I ran just one manual LAVA job with a chromeos-6.12 build w/ Clang 17 (build was successful and boots) - see https://lava.collabora.dev/scheduler/job/17616230 for reference I'll wait for the staging results to confirm if the other branches built successfully. |
@nuclearcat is there some way to manually trigger all related builds on staging once? should I process that myself with kci-dev? |
a7649da
to
bab41cf
Compare
Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new Clang kbuild jobs for both ARM64 and x86_64 Chromebooks. Signed-off-by: Laura Nao <[email protected]>
Refined branch filtering on the GCC builds as follows:
Added also missing entries in scheduler file. Will check results on staging again and report back. |
I checked the results on staging and can confirm the configuration looks correct. There were some build failures reported (e.g. https://staging.kernelci.org:9000/viewer?node_id=67ab73cd80912107775e4b6d), but they look like actual failures that can be investigated/fixed later. There were also some incomplete jobs (e.g.: https://staging.kernelci.org:9000/viewer?node_id=67ab73c980912107775e4b4f), reporting the |
They are likely infrastructure issues, as staging restart often. Just retry one more time, but if it repeats on same jobs - i will investigate it step by step. |
I think we will merge and investigate if any issues happen |
Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new Clang kbuild jobs for both ARM64 and x86_64 Chromebooks.