Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): Add plugin for Apache Druid #182

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

shrutimantri
Copy link
Contributor

What changes are being made and why?

Added plugin for Apache Druid with support for both query and trigger
Query
Screenshot 2023-12-04 at 1 51 17 PM
Screenshot 2023-12-04 at 1 51 32 PM
Trigger
Screenshot 2023-12-04 at 2 43 47 PM
Screenshot 2023-12-04 at 2 43 28 PM

How the changes have been QAed?

This has been QAed by running locally. Screenshot for the same has been added above.

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot.

I refactor a bit the test for better core readability and reliability.

Tests didn't pass in CI but Druid tests are passing, I'll check if I can merge as is, I suspect a test that didn't pass since a few days.

@loicmathieu
Copy link
Member

Rockset tests are failing but they are also failing in the master branch.
Druid tests passed so I'll merge this PR.

@loicmathieu loicmathieu merged commit a465a20 into kestra-io:master Dec 5, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants