Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to eliminate broadcasting in trajectory initialization by using the NamedTrajectories
merge
call, see kestrelquantum/NamedTrajectories.jl#54The price to pay is some copying.
The benefit is that this puts the burden of initialization for problems like direct sums and sampling onto the problem template. It forces the problem template to be aware of naming, which is good for programming at the level of problem templates.
For example, a clean loop for setting up a sampling problem with a lot of complexity like separate goals, separate systems, and so on: