Overhaul custom control setup #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasnetau
force-pushed
the
custom-static
branch
from
25046b8
to
be713a7
Compare
…se it per formBuilder instance. This ensures definitions set in one formBuilder do not interact with definitions in other formBuilder instances
lucasnetau
force-pushed
the
custom-static
branch
from
be713a7
to
203cac7
Compare
kevinchappell
approved these changes
Oct 19, 2023
| type: 'checkbox-group', | ||
| subtype: 'custom-group', | ||
| label: 'Custom Checkbox Group w/Sub Type', | ||
| required: !0, |
There was a problem hiding this comment.
just curious, why not just true?
There was a problem hiding this comment.
Can't answer that. I'm not sure if it was my IDE that did that or if I copy/pasted the example from somewhere. I know webpack has a habit of using !0 for true
|
🎉 This PR is included in version 3.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom controls we loaded globally via static methods and properties in custom.js, each formBuilder instance would remove the old definitions before adding their own in. This meant that field definitions would appear in the controls in earlier formBuilders however would throw an error when clicked because the definition has been removed
This PR reworks the custom controls by introducing a per instance container to register and retrieve custom control registrations. A proxy class is used to map template to the controlCustom class.
Closes #1090