Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-1477 userData incorrect when unchecking defaulted selected checkboxes #1478

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

lucasnetau
Copy link
Collaborator

@kevinchappell I believe setting this default empty array is the best method to ensure than when no value is available it is set. This ensures that any default values are not selected on subsequent loads.

Fixes: #1477

… userData otherwise there is no ability to save state when default selected checkboxes are all unchecked
@kevinchappell
Copy link
Owner

@kevinchappell I believe setting this default empty array is the best method to ensure than when no value is available it is set. This ensures that any default values are not selected on subsequent loads.

Fixes: #1477

I agree, that is a good solution

@kevinchappell kevinchappell merged commit bf73b76 into kevinchappell:master Nov 1, 2023
1 check passed
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 3.16.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userData is undefined for checkbox-group if no options selected, should be empty array
2 participants