-
Notifications
You must be signed in to change notification settings - Fork 26
Standard #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lloricode
wants to merge
16
commits into
kevinkhill:master
Choose a base branch
from
lloricode:feature/type-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Standard #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lloricode
commented
Nov 3, 2023
•
edited
Loading
edited
- Use laravel/pint for code style fixes
- Drop support PHP 8.2 below (see php 8.1 will soon end of life https://php.watch/versions)
- Use Pest for testing
- Use phpstan for static analysis (max rule level 10)
- Add github actions
- Replace travis with github action workflow
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
Signed-off-by: Lloric Mayuga Garcia <[email protected]>
hi @kevinkhill! hope you review this, thank you |
Oh wow, you really overhauled everything. I am interested to see what you
did. I'll try and take a look sometime soon. Thank you! 🙏
…On Sat, Apr 26, 2025, 8:21 AM Lloric Mayuga Garcia ***@***.***> wrote:
*lloricode* left a comment (kevinkhill/php-duration#29)
<#29 (comment)>
hi @kevinkhill <https://github.com/kevinkhill>! hope you review this,
thank you
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACA6XGXKMXAUUKKA4JHZQL23OQA7AVCNFSM6AAAAAB35PCY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGMYTINBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
been tested on production, and it is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.