Remove hardcoded locale environment variables #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 109 hardcodes the environment variable locales to
C
:but this conflicts with certain PKGBUILDs.
For example when extracting source files of the
sabnzbd
packagebsdtar
would complain:and fail the playbook.
The host machine locales were right, with UTF-8.
So removing the locale variables:
def_lang = ['env']
and using either:or nothing made it work.
Just as a note, setting:
makes it fail again.
This can be tested with
bsdtar
directly:Download the tar.gz source file from https://aur.archlinux.org/packages/sabnzbd
and it should error out.
Any special reason for keeping it? If anyone needs to specify them,
like any other env. var, the
environment
key works fine, given the useof
env
. And the good thing is that it can be used at the play, block, or task level.