[WIP] Replace the spin by a helicity property for the MCParticle #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is not safely interpretable without the full spin density matrix from the generator, whereas helicity is always well defined.
m-fila
reviewed
Feb 5, 2025
| ::edm4hep::Vector3d momentum{}; ///< particle 3-momentum at the production vertex [GeV] | ||
| ::edm4hep::Vector3d momentumAtEndpoint{}; ///< particle 3-momentum at the endpoint [GeV] | ||
| ::edm4hep::Vector3f spin{}; ///< particle spin | ||
| Vector2i colorFlow{}; |
There was a problem hiding this comment.
Should this still include the colorFlow and Vector2ithat were removed earlier?
There was a problem hiding this comment.
Yes, I think so, because the decisive factor is the schema version and for schema version 2, these were still there. But I am still debugging why this isn't work as expected yet. I have the feeling we are not tricking ROOT properly yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
spinbyhelicityinMCParticleas the former is not usable without the full spin-density matrix whereas the latter is always well defined (or unset).9which is used to signify an unset value. UsehasHelicityto check whether thehelicityis setENDRELEASENOTES
spin.zwill end up inhelicityas that seems to be the main way thatspinhas been populated in the past in LCIO.