Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Stable url for keyboard download no longer works #474

Closed
LornaSIL opened this issue Sep 25, 2024 · 1 comment · Fixed by #475
Closed

bug: Stable url for keyboard download no longer works #474

LornaSIL opened this issue Sep 25, 2024 · 1 comment · Fixed by #475
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LornaSIL
Copy link
Contributor

Our sldr files use this form of url to reference a keyboard, but it just goes to the home page for the keyboard:
https://keyman.com/go/keyboard/sil_euro_latin/download/kmp

This one works: https://keyman.com/go/package/download/sil_euro_latin

However, @mcdurdin says the first one is recommended and the second one is not a publicly stable one.

This is possibly a bug coming out of our move to Docker with Apache recently.

@LornaSIL LornaSIL changed the title bug: bug: Stable url for keyboard download no longer works Sep 25, 2024
@darcywong00 darcywong00 self-assigned this Sep 25, 2024
@darcywong00 darcywong00 added this to the A18S11 milestone Sep 25, 2024
@darcywong00 darcywong00 added the bug Something isn't working label Sep 25, 2024
@darcywong00
Copy link
Contributor

darcywong00 commented Sep 25, 2024

Preliminary investigation:

Original IIS rule

keyman.com/go/web.config

Lines 21 to 25 in ab3d0a4

<!-- TODO: these three rules need refresh -->
<rule name="download-kmp" stopProcessing="true">
<match url="^keyboard/([^/?]+)/download/kmp$" />
<action type="Redirect" url="/keyboards/download?id={R:1}&amp;platform=windows&amp;mode=standalone" />
</rule>

Current .htaccess rule

keyman.com/go/.htaccess

Lines 10 to 11 in b695ba0

# download-kmp
RedirectMatch "/go/keyboard/([^/?]+)/download/kmp$" "/keyboards/download?id=$1&platform=windows&mode=standalone"

Seems both go to /keyboards/download?id=$1&platform=windows&mode=standalone

Will check if that's supposed to load a page or redirect to a kmp file
Following where /keyboards/download goes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants