Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Specify HTML lang tag "en" 📓 #489

Merged
merged 7 commits into from
Nov 1, 2024
Merged

fix: Specify HTML lang tag "en" 📓 #489

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c15815e
fix: Specify HTML lang tag "en"
darcywong00 Oct 29, 2024
75b566e
Use $fields->language for setting the HTML language
darcywong00 Oct 31, 2024
71fb0b8
Merge branch 'master' into fix/html-lang
mcdurdin Oct 31, 2024
843c813
Update _includes/2020/templates/Head.php
darcywong00 Nov 1, 2024
d4608b0
Update _includes/2020/templates/Head.php
darcywong00 Nov 1, 2024
56452a3
chore: Apply suggestions from code review
mcdurdin Nov 1, 2024
1f0e371
chore: Update _includes/2020/templates/Head.php
mcdurdin Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion _includes/2020/templates/Head.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ static function render($fields = []) {
if(!isset($fields->title)) {
$fields->title = 'Keyman | Type to the world in your language';
}
if(empty($fields->language()) {
mcdurdin marked this conversation as resolved.
Show resolved Hide resolved
$fields->language = 'en'; // Default to English
}
if(!isset($fields->favicon)) {
$fields->favicon = Util::cdn("img/favicon.ico");
}
Expand All @@ -23,7 +26,7 @@ static function render($fields = []) {
$fields->js = [];
}
?><!DOCTYPE html>
<html>
<html lang="<?= $fields->language; ?>">
mcdurdin marked this conversation as resolved.
Show resolved Hide resolved
<head>
<meta charset="utf-8">
<?php
Expand Down
Loading