Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude /donate from broken link checker #492

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mcdurdin
Copy link
Member

/donate redirects to another site that gives a 403 forbidden response to bots, which breaks the link checker. So just exclude it.

Fixes: #488

/donate redirects to another site that gives a 403 forbidden response to
bots, which breaks the link checker. So just exclude it.

Fixes: #488
@mcdurdin mcdurdin added this to the A18S14 milestone Oct 31, 2024
@mcdurdin mcdurdin added the fix label Oct 31, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the CI link check passes

@mcdurdin
Copy link
Member Author

Hmm, turns out that there are 4 references to broken-link-checker. I can understand 2 of them, and no obvious way to consolidate those, but not sure why we have the ones in composer.json as well, would recommend removing them?

@darcywong00
Copy link
Contributor

but not sure why we have the ones in composer.json as well, would recommend removing them?

Ah, I added the one in composer.json in #389 for feature parity with help.keyman.com

I suppose we can remove in a separate PR

@mcdurdin
Copy link
Member Author

Ah, I added the one in composer.json in #389 for feature parity with help.keyman.com

Hmm, so we should probably remove from all then. Let's keep composer.json minimal, remove all scripts, seeing as we do them in ci.yml now?

I see we never call composer run test either, which means we should probably add vendor/bin/phpunit --testdox to ci.yml and/or Dockerfile?

How do we run lint and phpunit tests locally?

@darcywong00
Copy link
Contributor

I see we never call composer run test either, which means we should probably add vendor/bin/phpunit --testdox to ci.yml and/or Dockerfile?

How do we run lint and phpunit tests locally?

Looks like a TODO 😞

# TODO: lint tests

@mcdurdin
Copy link
Member Author

Okay, added #493 to track composer.json/test changes

@mcdurdin mcdurdin merged commit d345f11 into master Oct 31, 2024
2 checks passed
@mcdurdin mcdurdin deleted the fix/488-broken-link-checker-donate-ref branch October 31, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: /donate giving HTTP/403 in link checker
2 participants