-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exclude /donate from broken link checker #492
Conversation
/donate redirects to another site that gives a 403 forbidden response to bots, which breaks the link checker. So just exclude it. Fixes: #488
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming the CI link check passes
Hmm, turns out that there are 4 references to broken-link-checker. I can understand 2 of them, and no obvious way to consolidate those, but not sure why we have the ones in composer.json as well, would recommend removing them? |
Ah, I added the one in composer.json in #389 for feature parity with help.keyman.com I suppose we can remove in a separate PR |
Hmm, so we should probably remove from all then. Let's keep composer.json minimal, remove all scripts, seeing as we do them in ci.yml now? I see we never call How do we run lint and phpunit tests locally? |
Looks like a TODO 😞 Line 31 in 03025d8
|
Okay, added #493 to track composer.json/test changes |
/donate redirects to another site that gives a 403 forbidden response to bots, which breaks the link checker. So just exclude it.
Fixes: #488