chore(developer): add baseline tests for bcp47 codes to kmc-package #12506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
srl295
approved these changes
Oct 11, 2024
…rove-support-for-bcp47
mcdurdin
requested review from
darcywong00,
SabineSIL and
markcsinclair
as code owners
keymanapp-test-bot
bot
removed
the
user-test-missing
|
Developer build failed due to network glitch, not chasing this, all looks fine. |
|
Changes in this pull request will be available for download in Keyman version 18.0.154-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly minimal but at leasts verifies that a clearly invalid BCP47 tag is blocked and some more unusual but valid tags pass.
Relates-to: #12012
@keymanapp-test-bot skip