chore(developer): make package subfile description fully optional #12665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package subfile description field is never really used in the end-user apps. As it is meaningless metadata, we'll make it fully optional, and start to remove all references in the designers and compilers. TODO: For packages targeting Keyman 18.0+, we should consider removing the description field altogether from the subfiles.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
commented
Nov 21, 2024
| @@ -93,7 +93,7 @@ function do_test() { | |||
|
|
|||
| #------------------------------------------------------------------------------------------------------------------- | |||
|
|
|||
| builder_run_action clean rm -rf ./build/ ./tsconfig.tsbuildinfo | |||
| builder_run_action clean rm -rf ./build/ ./tsconfig.tsbuildinfo ./src/schemas/ ./node_modules/ ./obj/ | |||
There was a problem hiding this comment.
This is not related but not worth splitting into a separate PR IMO. Just means clean really does a proper clean of all built files in common/web/types. Doesn't impact CI really.
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair,
srl295 and
jahorton
as code owners
srl295
approved these changes
Nov 21, 2024
See #12682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package subfile description field is never really used in the end-user apps. As it is meaningless metadata, we'll make it fully optional, and start to remove all references in the designers and compilers.
TODO: For packages targeting Keyman 18.0+, we should consider removing the description field altogether from the subfiles. This should be done in a separate PR.
@keymanapp-test-bot skip