fix: resolve footer website name cut-off or overlap issue #444

m7md-Y-3mra · 2024-09-17T16:54:33Z

User description

Description

Give a summary of the change that you have made

I fixed the issue where the website name in the footer was either partially displayed or overlapped with other elements. The website name is now fully visible and responsive, regardless of the screen size.

Fixes #433

Dependencies

Mention any dependencies/packages used
No additional dependencies or packages were used for this fix.

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

My PR follows the style guidelines of this project
I have performed a self-check on my work

If changes are made in the code:

I have followed the coding guidelines
My changes in code generate no new warnings
My changes are breaking another fix/feature of the project
I have added test cases to show that my feature works
I have added relevant screenshots in my PR
There are no UI/UX issues

Documentation Update

This PR requires an update to the documentation at docs.keyshade.xyz
I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

bug_fix

Description

Fixed the issue where the footer website name was cut-off or overlapped by un-commenting and properly wrapping the FooterLogoSVG component.
Ensured the FooterLogoSVG is displayed with appropriate padding to prevent overlap.

Changes walkthrough 📝

Relevant files

Bug fix

index.tsx `Fix footer website name visibility issue` apps/web/src/components/shared/footer/index.tsx Un-commented the `FooterLogoSVG` component to ensure it is displayed. Wrapped the `FooterLogoSVG` component in a `div` with padding.	+3/-3

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

codiumai-pr-agent-free · 2024-09-17T16:54:51Z

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

codiumai-pr-agent-free · 2024-09-17T16:55:04Z

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	✅ Add responsive padding classes to ensure proper spacing on different screen sizes Suggestion Impact: The commit added a responsive padding class "pb-[2vw]" to the logo container, which aligns with the suggestion to ensure proper spacing on different screen sizes. code diff: + <div className="w-[90%] mx-auto flex justify-center items-center"> + <div className="mt-5 lg:flex"> - <div className="mt-5 w-[60%] justify-between md:flex"> - <div className="pr-[2vw]"> - <FooterLogoSVG /> - </div> + <div className="pr-[2vw] pb-[2vw]"> + <FooterLogoSVG /> + </div> Consider adding a responsive padding class to ensure proper spacing on different screen sizes. This can help prevent the logo from being too close to other elements on smaller screens. apps/web/src/components/shared/footer/index.tsx [30-32] -<div className="pr-[2vw]"> +<div className="pr-[2vw] md:pr-[3vw] lg:pr-[4vw]"> <FooterLogoSVG /> </div> Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding responsive padding classes enhances the user interface by ensuring that the logo maintains appropriate spacing across different screen sizes, which is important for a consistent and visually appealing design.	8
Best practice	Use a more specific class name for the logo wrapper to improve code maintainability Consider using a more specific class name for the padding, such as `footer-logo-wrapper`, instead of relying on a generic padding class. This improves code readability and maintainability. apps/web/src/components/shared/footer/index.tsx [30-32] -<div className="pr-[2vw]"> +<div className="footer-logo-wrapper"> <FooterLogoSVG /> </div> Apply this suggestion Suggestion importance[1-10]: 7 Why: Using a more specific class name like `footer-logo-wrapper` can improve code readability and maintainability by making the purpose of the class clearer. However, this is a minor improvement and not crucial to the functionality.	7

💡 Need additional feedback ? start a PR chat

rajdip-b · 2024-09-18T04:24:56Z

@kriptonian1 drop in a review

kriptonian1

LGTM

…yz#444) Co-authored-by: m7md-Y-3mar <[email protected]>

## [2.6.0](v2.5.0...v2.6.0) (2024-10-24) ### 🚀 Features * **api:** Add icon and remove description field from workspace ([#435](#435)) ([a99c0db](a99c0db)) * **api-client:** Added workspace-membership and related tests ([#452](#452)) ([6a1c091](6a1c091)) * **api-client:** Create controller for User module ([#484](#484)) ([f9d8e83](f9d8e83)) * **api:** Add prod env schema in env file ([#436](#436)) ([21c3004](21c3004)) * **api:** Add resend otp implementation ([#445](#445)) ([4dc6aa1](4dc6aa1)) * **api:** Fetch total count of environments, [secure]s and variables in project ([#434](#434)) ([0c9e50a](0c9e50a)) * **api:** Replace `projectId` with `name` and `slug` in workspace-role response. ([#432](#432)) ([af06071](af06071)) * **cli:** Add functionality to operate on Secrets ([#504](#504)) ([1b4bf2f](1b4bf2f)) * **cli:** Add project command ([#451](#451)) ([70448e1](70448e1)) * **cli:** Add workspace operations ([#441](#441)) ([ed38d22](ed38d22)) * **cli:** implement commands to get, list, update, and delete, workspace roles ([#469](#469)) ([957ea8d](957ea8d)) * **cli:** Implemented pagination support ([#453](#453)) ([feb1806](feb1806)) * **cli:** Secret scan ([#438](#438)) ([85cb8ab](85cb8ab)) * **cli:** Update environment command outputs ([f4af874](f4af874)) * **platform:** Clearing email field after waitlisting the user email ([#481](#481)) ([256d659](256d659)) * Remove project IDs from workspace role export data and update tests ([#448](#448)) ([8fdb328](8fdb328)) * **web:** Configured extra check for waitlisted users already in the list and created toast message for them ([#492](#492)) ([2ddd0ef](2ddd0ef)) * **web:** show the toast only when email add successfully ([#490](#490)) ([783c411](783c411)) ### 🐛 Bug Fixes * **api,api-client:** Add environmentSlug in multiple places across the variable module ([#468](#468)) ([d970aff](d970aff)) * **api:** Replace the id with slug in the global-search service ([#455](#455)) ([74804b1](74804b1)) * **platform:** Fixed duplicate Google Logo UI fix ([#450](#450)) ([fb0d6f7](fb0d6f7)) * resolve footer website name cut-off or overlap issue ([#444](#444)) ([fe03ba2](fe03ba2)) * **web:** Horizontal Scrolling issue on the website ([#440](#440)) ([655177b](655177b)) ### 📚 Documentation * Add documentation for environment in CLI ([#462](#462)) ([dad7394](dad7394)) * Add documentation for project in CLI ([#466](#466)) ([341fb32](341fb32)) * Add documentation for scan in CLI ([#461](#461)) ([72281e6](72281e6)) * Add documentation for workspace command ([#464](#464)) ([4aad8a2](4aad8a2)) * Add instructions for resetting the local Prisma database ([#495](#495)) ([#501](#501)) ([b07ea17](b07ea17)) * Added docker support documentation ([#465](#465)) ([bc04be4](bc04be4)) * Added documentation for running the platform ([#473](#473)) ([8b8386b](8b8386b)) * Added missing mappings to pages ([5de9fd8](5de9fd8)) * Fix Documentation Hyperlink and update expired Discord invite link ([#496](#496)) ([5a10e39](5a10e39)) * Updated CLI docs ([#460](#460)) ([c7e0f13](c7e0f13)) ### 🔧 Miscellaneous Chores * Add more logging to Sentry init ([#470](#470)) ([de4925d](de4925d)) * **api:** Optimise API docker image size ([#360](#360)) ([ea40dc1](ea40dc1)) * **api:** Updated lockfile ([a968e78](a968e78)) * **CI:** Add [secure] scan validation ([f441262](f441262)) * **cli:** Update controller invocation in environment commands ([#477](#477)) ([596bd1a](596bd1a)) * Minor changes to variables ([fe01ca6](fe01ca6)) * **[secure]-scan:** Failing lint issues ([#507](#507)) ([48f45df](48f45df)) * **[secure]-scan:** Formatted files ([5884833](5884833)) * Update .env.example ([70ad4f7](70ad4f7)) * Updated scripts ([9eb76a7](9eb76a7)) * **web:** email validation ([#487](#487)) ([e8e737a](e8e737a))

rajdip-b · 2024-10-24T12:12:31Z

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

m7md-Y-3mra requested a review from kriptonian1 as a code owner September 17, 2024 16:54

codiumai-pr-agent-free bot added bug_fix Review effort [1-5]: 1 labels Sep 17, 2024

m7md-Y-3mra mentioned this pull request Sep 17, 2024

WEB: Website logo cut off or overlaps in footer #433

Closed

rajdip-b force-pushed the fix/footer-name-visibility branch from dcbcad1 to eb10de3 Compare September 18, 2024 04:24

m7ad3mra added 2 commits September 18, 2024 10:16

fix: resolve footer website name cut-off or overlap issue

a54c3d9

fix: ensure website name in footer is fully visible

20a37fb

m7md-Y-3mra force-pushed the fix/footer-name-visibility branch from eb10de3 to 20a37fb Compare September 18, 2024 07:50

kriptonian1 approved these changes Sep 18, 2024

View reviewed changes

kriptonian1 merged commit fe03ba2 into keyshade-xyz:develop Sep 18, 2024
4 checks passed

Kiranchaudhary537 pushed a commit to Kiranchaudhary537/keyshade that referenced this pull request Oct 13, 2024

fix: resolve footer website name cut-off or overlap issue (keyshade-x…

cac881b

…yz#444) Co-authored-by: m7md-Y-3mar <[email protected]>

rajdip-b added the released label Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve footer website name cut-off or overlap issue #444

fix: resolve footer website name cut-off or overlap issue #444

m7md-Y-3mra commented Sep 17, 2024 •

edited

Loading

codiumai-pr-agent-free bot commented Sep 17, 2024

codiumai-pr-agent-free bot commented Sep 17, 2024 •

edited

Loading

rajdip-b commented Sep 18, 2024

kriptonian1 left a comment

rajdip-b commented Oct 24, 2024

fix: resolve footer website name cut-off or overlap issue #444

fix: resolve footer website name cut-off or overlap issue #444

Conversation

m7md-Y-3mra commented Sep 17, 2024 • edited Loading

User description

Description

Dependencies

Future Improvements

Mentions

Screenshots of relevant screens

Developer's checklist

Documentation Update

PR Type

Description

Changes walkthrough 📝

codiumai-pr-agent-free bot commented Sep 17, 2024

PR Reviewer Guide 🔍

codiumai-pr-agent-free bot commented Sep 17, 2024 • edited Loading

PR Code Suggestions ✨

rajdip-b commented Sep 18, 2024

kriptonian1 left a comment

Choose a reason for hiding this comment

rajdip-b commented Oct 24, 2024

m7md-Y-3mra commented Sep 17, 2024 •

edited

Loading

codiumai-pr-agent-free bot commented Sep 17, 2024 •

edited

Loading