-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Redirect users to login page upon 403 on getSelf #656 #662
Closed
Ahmed-Sami-Abdelaleem
wants to merge
3
commits into
keyshade-xyz:develop
from
Ahmed-Sami-Abdelaleem:develop
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import { APIClient } from "../src/APIClient"; | ||
import { rest } from "msw"; | ||
import { setupServer } from "msw/node"; | ||
|
||
const backendUrl = process.env.BACKEND_URL | ||
const apiClient = new APIClient(backendUrl); | ||
|
||
// Mock server for API requests | ||
const server = setupServer( | ||
rest.get(`${backendUrl}/test`, (req, res, ctx) => { | ||
return res(ctx.status(200), ctx.json({ message: "Success" })); | ||
}), | ||
rest.get(`${backendUrl}/auth-required`, (req, res, ctx) => { | ||
return res(ctx.status(403), ctx.json({ message: "Forbidden" })); | ||
}) | ||
); | ||
|
||
beforeAll(() => server.listen()); | ||
afterEach(() => server.resetHandlers()); | ||
afterAll(() => server.close()); | ||
|
||
describe("APIClient", () => { | ||
beforeEach(() => { | ||
localStorage.clear(); | ||
document.cookie = ""; | ||
}); | ||
|
||
it("should fetch data successfully", async () => { | ||
const response = await apiClient.get("/test"); | ||
const data = await response.json(); | ||
|
||
expect(response.status).toBe(200); | ||
expect(data.message).toBe("Success"); | ||
}); | ||
|
||
it("should clear local data and redirect on 403 Forbidden", async () => { | ||
// Mock window.location.href | ||
delete (window as any).location; | ||
(window as any).location = { href: "" }; | ||
|
||
await expect(apiClient.get("/auth-required")).rejects.toThrow( | ||
"User is not authenticated. Redirecting to /auth." | ||
); | ||
|
||
// Verify localStorage is cleared | ||
expect(localStorage.length).toBe(0); | ||
|
||
// Verify cookies are cleared | ||
expect(document.cookie).toBe(""); | ||
|
||
// Verify redirection | ||
expect(window.location.href).toBe("/auth"); | ||
}); | ||
|
||
it("should handle other HTTP errors gracefully", async () => { | ||
server.use( | ||
rest.get(`${baseUrl}/error`, (req, res, ctx) => { | ||
return res(ctx.status(500), ctx.json({ message: "Server Error" })); | ||
}) | ||
); | ||
|
||
const response = await apiClient.get("/error"); | ||
expect(response.status).toBe(500); | ||
|
||
const data = await response.json(); | ||
expect(data.message).toBe("Server Error"); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't have this code in here. The call needs to be tapped in the
platform
appThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry if the issue description wasn't descriptive enough!