-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub Scanning app #663
base: develop
Are you sure you want to change the base?
Conversation
…pes to @keyshade/schema (keyshade-xyz#569) Co-authored-by: Rajdip Bhattacharya <[email protected]>
Co-authored-by: rajdip-b <[email protected]>
## [2.8.0](keyshade-xyz/keyshade@v2.7.0...v2.8.0) (2024-12-03) ### 🚀 Features * **api:** Add workspace removal notification email template ([keyshade-xyz#476](keyshade-xyz#476)) ([40b754f](keyshade-xyz@40b754f)) * **cli:** Store `metrics_enabled` key in profile config ([keyshade-xyz#536](keyshade-xyz#536)) ([9283b22](keyshade-xyz@9283b22)) * **package, api, cli:** Add api-key schemas and types; Fix schema inconsistencies; Minor fix for CLI build errors ([keyshade-xyz#557](keyshade-xyz#557)) ([126d024](keyshade-xyz@126d024)) * **platform:** Added screen for CREATE NEW PROJECT ([keyshade-xyz#540](keyshade-xyz#540)) ([b644633](keyshade-xyz@b644633)) * **platform:** Updated the empty state of dashboard ([keyshade-xyz#522](keyshade-xyz#522)) ([28739d9](keyshade-xyz@28739d9)) * **schema, api-client:** Migrate auth types to @keyshade/schema ([keyshade-xyz#532](keyshade-xyz#532)) ([d880098](keyshade-xyz@d880098)) * **schema, api-client:** Migrate event schemas and types to @keyshade/schema ([keyshade-xyz#546](keyshade-xyz#546)) ([a3267de](keyshade-xyz@a3267de)) * **schema, api-client:** Migrate integration schemas and types to @keyshade/schema ([keyshade-xyz#547](keyshade-xyz#547)) ([08868c3](keyshade-xyz@08868c3)) * **schema, api-client:** Migrate project schemas and environment schemas along with their types to @keyshade/schema ([keyshade-xyz#538](keyshade-xyz#538)) ([c468af0](keyshade-xyz@c468af0)) * **schema, api-client:** Migrate [secure] types and schemas to @keyshade/schema ([keyshade-xyz#539](keyshade-xyz#539)) ([bc3100b](keyshade-xyz@bc3100b)) * **schema, api-client:** Migrate user types and schemas to @keyshade/schema ([keyshade-xyz#535](keyshade-xyz#535)) ([c24695e](keyshade-xyz@c24695e)) * **schema, api-client:** Migrate variable schemas and types to @keyshade/schema ([keyshade-xyz#545](keyshade-xyz#545)) ([0ee8f9a](keyshade-xyz@0ee8f9a)) * **schema, api-client:** Migrate workspace-membership schemas and types to @keyshade/schema ([keyshade-xyz#569](keyshade-xyz#569)) ([4398969](keyshade-xyz@4398969)) * **schema, api-client:** Migrate workspace-role schemas and types to @keyshade/schema ([keyshade-xyz#568](keyshade-xyz#568)) ([9efbf2d](keyshade-xyz@9efbf2d)) * **schema:** Add User type inference from UserSchema ([keyshade-xyz#574](keyshade-xyz#574)) ([84c1db5](keyshade-xyz@84c1db5)) ### 🐛 Bug Fixes * **api:** Incorrect oauth redirect url ([58d96e5](keyshade-xyz@58d96e5)) * **platform:** Resolve loading SVG blocking input field interaction ([keyshade-xyz#571](keyshade-xyz#571)) ([30f4f65](keyshade-xyz@30f4f65)) ### 📚 Documentation * Add pictures to Bruno setup ([keyshade-xyz#541](keyshade-xyz#541)) ([210c0fd](keyshade-xyz@210c0fd)) * Migrate to Bruno ([keyshade-xyz#525](keyshade-xyz#525)) ([1793d92](keyshade-xyz@1793d92)) ### 🔧 Miscellaneous Chores * **ci:** Add script to validate schema package ([59e4280](keyshade-xyz@59e4280)) * Fixed codecov client version ([a998ae4](keyshade-xyz@a998ae4)) * **package:** Fixed tests and did housekeeping ([keyshade-xyz#544](keyshade-xyz#544)) ([40008e3](keyshade-xyz@40008e3)) * Update test coverage settings ([5b27e32](keyshade-xyz@5b27e32)) * Update Turbo to 2.3.1 ([keyshade-xyz#564](keyshade-xyz#564)) ([3a63823](keyshade-xyz@3a63823)) * **web:** Update dockerfile ([10d9cc5](keyshade-xyz@10d9cc5)) ### 🔨 Code Refactoring * **api-client, schema:** Add workspace's schemas and types in @keyshade/schema ([keyshade-xyz#520](keyshade-xyz#520)) ([7c8ee5d](keyshade-xyz@7c8ee5d))
…e-xyz#480) Co-authored-by: Rajdip Bhattacharya <[email protected]>
…keyshade-xyz#586) Co-authored-by: Rajdip Bhattacharya <[email protected]>
…ation (keyshade-xyz#579) Co-authored-by: Rajdip Bhattacharya <[email protected]>
…hade-xyz#589) Co-authored-by: Rajdip Bhattacharya <[email protected]>
…onse (keyshade-xyz#590) Co-authored-by: rajdip-b <[email protected]>
…ient` (keyshade-xyz#584) Co-authored-by: rajdip-b <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Looks like we have a lot of conflicts! |
User description
Description
Created a Next.js app with GitHub scanner class under util to clone and use secret-scan on it.
Adds HTTP streaming response from API.
Related to #565
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement, Tests
Description
Added a GitHub repository scanner for secret detection, including support for
.gitignore
and binary file exclusions.Enhanced project management UI with updated API integration for secret and project handling.
Refactored multiple services and components for improved performance, maintainability, and modularity.
Introduced CLI commands for managing workspace memberships, including invitations, role updates, and ownership transfers.
Added reusable UI components like
Select
and improved email templates using React Email.Expanded test coverage across schemas, APIs, and services with additional validations, edge cases, and modular test structures.
Changes walkthrough 📝
17 files
project.spec.ts
Expanded schema test coverage with additional cases and validations.
packages/schema/tests/project.spec.ts
ProjectWithCountSchema
,CreateProjectRequestSchema
,UpdateProjectRequestSchema
, and others.multiple schemas.
describe
blocks for better readabilityand structure.
secret.spec.ts
Enhanced secret schema tests with additional validations.
packages/schema/tests/secret.spec.ts
SecretSchema
,CreateSecretRequestSchema
,UpdateSecretResponseSchema
, and others.incorrect data types.
describe
blocks for better modularity andclarity.
workspace.spec.ts
Improved workspace schema tests with additional cases and validations.
packages/schema/tests/workspace.spec.ts
InviteMemberRequestSchema
,CreateWorkspaceRequestSchema
, and others.incorrect data types.
describe
blocks for better modularity andclarity.
user.spec.ts
Expanded user schema tests with additional validations and cases.
packages/schema/tests/user.spec.ts
UserSchema
,GetSelfResponseSchema
,UpdateSelfRequestSchema
, and others.incorrect data types.
describe
blocks for better modularity andclarity.
variable.e2e.spec.ts
Added tests for variable versioning and metadata validation.
apps/api/src/variable/variable.e2e.spec.ts
variables.
integration.spec.ts
Refactor and enhance integration schema test cases.
packages/schema/tests/integration.spec.ts
describe
blocks for betterorganization.
expect
statements for validation results in tests.workspace-role.spec.ts
Refactor and expand workspace role schema tests.
packages/schema/tests/workspace-role.spec.ts
describe
blocks for clarity.inputs.
expect
statements to validate test outcomes.variable.spec.ts
Refactor and enhance variable schema test cases.
packages/schema/tests/variable.spec.ts
describe
blocks for better readability.expect
statements.api-key.spec.ts
Refactor and improve API key schema tests.
packages/schema/tests/api-key.spec.ts
describe
blocks.expect
statements for validation results.event.spec.ts
Refactor and enhance event schema test cases.
packages/schema/tests/event.spec.ts
describe
blocks for clarity.expect
statements.workspace-membership.e2e.spec.ts
Update workspace membership e2e tests with new validations.
apps/api/src/workspace-membership/workspace-membership.e2e.spec.ts
createdOn
field validation in workspace membership tests.environment.spec.ts
Refactor environment schema tests for better organization.
packages/schema/tests/environment.spec.ts
describe
blocks.
workspace-membership.spec.ts
Add workspace membership schema tests.
packages/schema/tests/workspace-membership.spec.ts
pagination.spec.ts
Refactor pagination schema tests for clarity.
packages/schema/tests/pagination.spec.ts
describe
blocks.enums.test.ts
Refactor and enhance enum tests.
packages/schema/tests/enums.test.ts
describe
blocks.workspace.e2e.spec.ts
Add workspace invitation and membership tests.
apps/api/src/workspace/workspace.e2e.spec.ts
secret.e2e.spec.ts
Add and enhance secret controller tests.
apps/api/src/secret/secret.e2e.spec.ts
scenarios.
10 files
workspace.command.ts
Add workspace membership command to CLI.
apps/cli/src/commands/workspace.command.ts
WorkspaceMembershipCommand
to the list of workspace commands.page.tsx
Update project management UI and integrate new API.
apps/platform/src/app/(main)/page.tsx
select.tsx
Add reusable Select component with Radix UI.
apps/platform/src/components/ui/select.tsx
Select
component using Radix UI primitives.project.service.ts
Refactor project service to include counts and modularize logic.
apps/api/src/project/service/project.service.ts
secret counts.
scan-repo.ts
Add GitHub repository scanner for secret detection.
apps/github-scanner/src/util/scan-repo.ts
data.
.gitignore
and binary file exclusions.workspace-removal.tsx
Refactor workspace removal email template.
apps/api/src/mail/emails/workspace-removal.tsx
secret.service.ts
Refactor secret service for optimized version handling.
apps/api/src/secret/service/secret.service.ts
page.tsx
Update secret page with new API integration.
apps/platform/src/app/(main)/project/[project]/@secret/page.tsx
mail.service.ts
Refactor email service to use React Email templates.
apps/api/src/mail/services/mail.service.ts
membership.workspace.ts
Add CLI commands for workspace membership management.
apps/cli/src/commands/workspace/membership.workspace.ts
transfers.
101 files