-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Workspace-membership invitationAccepted included #665
base: develop
Are you sure you want to change the base?
feat(api): Workspace-membership invitationAccepted included #665
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
192746f
to
77d69cf
Compare
@@ -516,7 +516,8 @@ export class WorkspaceMembershipService { | |||
} | |||
} | |||
} | |||
} | |||
}, | |||
invitationAccepted: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't always be true. This should come from the invitation status field in workspace membership model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invitationAccepted: true
is how Prisma configured to include a specific field in the return type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to get my eyes checked. Sorry :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the tests would work
Also, could you add relevant tests for this? |
This week I'm off. Next week I'll sort out this and all other issues too. |
Thanks! |
User description
Description
WorkspaceMember.invitationAccepted
returned in/api/workspace-membership/{workspaceSlug}/members
Fixes #406
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
Added
invitationAccepted
field to workspace membership API response.Enhanced
/api/workspace/{workspaceId}/members
endpoint to include membership status.Updated service logic to fetch and return invitation status.
Improved API functionality for better workspace member management.
Changes walkthrough 📝
workspace-membership.service.ts
Include invitation status in workspace membership API
apps/api/src/workspace-membership/service/workspace-membership.service.ts
invitationAccepted
field to the API response.