-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): Implement delete project #671
Conversation
CI Feedback 🧐(Feedback updated until commit e1a79c0)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [2.10.0-stage.7](v2.10.0-stage.6...v2.10.0-stage.7) (2025-01-28) ### 🚀 Features * **platform:** Implement delete project ([#671](#671)) ([d243c89](d243c89))
🎉 This PR is included in version 2.10.0-stage.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
LFG! |
## [2.10.0](v2.9.1...v2.10.0) (2025-01-28) ### 🚀 Features * **api:** Secret rotation ([#652](#652)) ([ad9a808](ad9a808)) * **platform:** Implement delete project ([#671](#671)) ([d243c89](d243c89)) * **platform:** Improved UI of [secure] listing ([#655](#655)) ([b19de47](b19de47)) * **platform:** Operate on environments ([#670](#670)) ([f45c5fa](f45c5fa)) ### 🐛 Bug Fixes * Added lockfile ([856eb3c](856eb3c)) * **api:** Only user's default workspace returns isDefault: true ([#647](#647)) ([870b4dc](870b4dc)) * **cli:** Workspace membership API client payload fixed ([#614](#614)) ([#648](#648)) ([e23057b](e23057b)) * **platform:** Refactor layout structure to improve Navbar positioning & child component ([#661](#661)) ([31067f3](31067f3)) * **Platfrom:** Replace manual date calculation with dayjs to improve better calculation ([#668](#668)) ([990eb86](990eb86)) ### 🔧 Miscellaneous Chores * **ci:** Add manual trigger ([cfbf4b9](cfbf4b9)) * **ci:** Add missing LATEST_TAG variable ([a2ea2ed](a2ea2ed)) * **ci:** Fixed misplaced sentry sourcemaps commands ([fbd6f3b](fbd6f3b)) * **ci:** Fixed scripts ([374f7ed](374f7ed)) * **ci:** Update API sentry dist folder ([2bc9afb](2bc9afb)) * **CI:** Update pipeline ([fd63b70](fd63b70)) * **ci:** Update sourcemap upload commands ([c7e8e45](c7e8e45)) * **cli:** Bumped CLI version to 2.5.0 ([7b772f8](7b772f8)) * Fix prerelease branch config ([7e84021](7e84021)) * **release:** 2.10.0-stage.1 [skip ci] ([a4f8414](a4f8414)), closes [#652](#652) * **release:** 2.10.0-stage.2 [skip ci] ([00ee123](00ee123)), closes [#647](#647) * **release:** 2.10.0-stage.3 [skip ci] ([941a815](941a815)), closes [#655](#655) * **release:** 2.10.0-stage.4 [skip ci] ([ae7c44f](ae7c44f)), closes [#614](#614) [#648](#648) * **release:** 2.10.0-stage.5 [skip ci] ([d718483](d718483)), closes [#661](#661) * **release:** 2.10.0-stage.6 [skip ci] ([4e63f47](4e63f47)), closes [#668](#668) * **release:** 2.10.0-stage.7 [skip ci] ([4a35fe7](4a35fe7)), closes [#671](#671) * **release:** 2.10.0-stage.8 [skip ci] ([36ef21d](36ef21d)), closes [#670](#670) * **release:** 2.9.2-stage.1 [skip ci] ([443f8d4](443f8d4)) ### 🔨 Code Refactoring * **api:** Update getSelf function ([fe752ce](fe752ce))
🎉 This PR is included in version 2.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Co-authored-by: Rajdip Bhattacharya <[email protected]>
## [2.10.0-stage.7](keyshade-xyz/keyshade@v2.10.0-stage.6...v2.10.0-stage.7) (2025-01-28) ### 🚀 Features * **platform:** Implement delete project ([keyshade-xyz#671](keyshade-xyz#671)) ([d243c89](keyshade-xyz@d243c89))
## [2.10.0](keyshade-xyz/keyshade@v2.9.1...v2.10.0) (2025-01-28) ### 🚀 Features * **api:** Secret rotation ([keyshade-xyz#652](keyshade-xyz#652)) ([ad9a808](keyshade-xyz@ad9a808)) * **platform:** Implement delete project ([keyshade-xyz#671](keyshade-xyz#671)) ([d243c89](keyshade-xyz@d243c89)) * **platform:** Improved UI of [secure] listing ([keyshade-xyz#655](keyshade-xyz#655)) ([b19de47](keyshade-xyz@b19de47)) * **platform:** Operate on environments ([keyshade-xyz#670](keyshade-xyz#670)) ([f45c5fa](keyshade-xyz@f45c5fa)) ### 🐛 Bug Fixes * Added lockfile ([856eb3c](keyshade-xyz@856eb3c)) * **api:** Only user's default workspace returns isDefault: true ([keyshade-xyz#647](keyshade-xyz#647)) ([870b4dc](keyshade-xyz@870b4dc)) * **cli:** Workspace membership API client payload fixed ([keyshade-xyz#614](keyshade-xyz#614)) ([keyshade-xyz#648](keyshade-xyz#648)) ([e23057b](keyshade-xyz@e23057b)) * **platform:** Refactor layout structure to improve Navbar positioning & child component ([keyshade-xyz#661](keyshade-xyz#661)) ([31067f3](keyshade-xyz@31067f3)) * **Platfrom:** Replace manual date calculation with dayjs to improve better calculation ([keyshade-xyz#668](keyshade-xyz#668)) ([990eb86](keyshade-xyz@990eb86)) ### 🔧 Miscellaneous Chores * **ci:** Add manual trigger ([cfbf4b9](keyshade-xyz@cfbf4b9)) * **ci:** Add missing LATEST_TAG variable ([a2ea2ed](keyshade-xyz@a2ea2ed)) * **ci:** Fixed misplaced sentry sourcemaps commands ([fbd6f3b](keyshade-xyz@fbd6f3b)) * **ci:** Fixed scripts ([374f7ed](keyshade-xyz@374f7ed)) * **ci:** Update API sentry dist folder ([2bc9afb](keyshade-xyz@2bc9afb)) * **CI:** Update pipeline ([fd63b70](keyshade-xyz@fd63b70)) * **ci:** Update sourcemap upload commands ([c7e8e45](keyshade-xyz@c7e8e45)) * **cli:** Bumped CLI version to 2.5.0 ([7b772f8](keyshade-xyz@7b772f8)) * Fix prerelease branch config ([7e84021](keyshade-xyz@7e84021)) * **release:** 2.10.0-stage.1 [skip ci] ([a4f8414](keyshade-xyz@a4f8414)), closes [keyshade-xyz#652](keyshade-xyz#652) * **release:** 2.10.0-stage.2 [skip ci] ([00ee123](keyshade-xyz@00ee123)), closes [keyshade-xyz#647](keyshade-xyz#647) * **release:** 2.10.0-stage.3 [skip ci] ([941a815](keyshade-xyz@941a815)), closes [keyshade-xyz#655](keyshade-xyz#655) * **release:** 2.10.0-stage.4 [skip ci] ([ae7c44f](keyshade-xyz@ae7c44f)), closes [keyshade-xyz#614](keyshade-xyz#614) [keyshade-xyz#648](keyshade-xyz#648) * **release:** 2.10.0-stage.5 [skip ci] ([d718483](keyshade-xyz@d718483)), closes [keyshade-xyz#661](keyshade-xyz#661) * **release:** 2.10.0-stage.6 [skip ci] ([4e63f47](keyshade-xyz@4e63f47)), closes [keyshade-xyz#668](keyshade-xyz#668) * **release:** 2.10.0-stage.7 [skip ci] ([4a35fe7](keyshade-xyz@4a35fe7)), closes [keyshade-xyz#671](keyshade-xyz#671) * **release:** 2.10.0-stage.8 [skip ci] ([36ef21d](keyshade-xyz@36ef21d)), closes [keyshade-xyz#670](keyshade-xyz#670) * **release:** 2.9.2-stage.1 [skip ci] ([443f8d4](keyshade-xyz@443f8d4)) ### 🔨 Code Refactoring * **api:** Update getSelf function ([fe752ce](keyshade-xyz@fe752ce))
User description
Description
This pull request introduces several changes to the
apps/platform
project, focusing on adding a delete project feature, improving the layout, and optimizing project fetching. The most important changes include the addition of a delete project confirmation dialog, updates to the project card component to support project deletion, and the use ofuseCallback
for fetching projects.Delete Project Feature:
ConfirmDeleteProject
component to handle project deletion confirmation (apps/platform/src/components/dashboard/project/confirmDeleteProject/index.tsx
).ProjectCard
to include delete project functionality and handle the delete project dialog (apps/platform/src/components/dashboard/project/projectCard/index.tsx
). [1] [2] [3] [4]Layout Improvements:
apps/platform/src/app/(main)/layout.tsx
). [1] [2]Project Fetch Optimization:
useCallback
for better performance and cleaner code (apps/platform/src/app/(main)/page.tsx
). [1] [2]ConfirmDeleteProject
into the main page to handle project deletion (apps/platform/src/app/(main)/page.tsx
). [1] [2]Fixes #657
Mentions
@rajdip-b @poswalsameer
Screenshots of relevant screens
Screen.Recording.2025-01-28.at.12.33.02.PM.mov
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
Added a delete project feature with confirmation dialog.
Refactored layout structure for improved readability.
Introduced
useCallback
for optimized project fetching.Updated project card to support project deletion.
Changes walkthrough 📝
layout.tsx
Refactor layout structure for readability
apps/platform/src/app/(main)/layout.tsx
page.tsx
Add delete project logic and optimize fetching
apps/platform/src/app/(main)/page.tsx
useCallback
for fetching projects.index.tsx
Add delete project confirmation component
apps/platform/src/components/dashboard/project/confirmDeleteProject/index.tsx
index.tsx
Add delete functionality to project card
apps/platform/src/components/dashboard/project/projectCard/index.tsx