-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): add workspace slug for projects in url #683
base: develop
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
I think we should use either of the following conventions:
|
User description
Description
This pull request includes several changes to the
ProjectCard
andNavbar
components in theapps/platform
directory. The most important changes include adding a new atom value, updating the project link to include the workspace slug, and modifying the pathname check in theNavbar
component.Updates to
ProjectCard
component:useAtomValue
import fromjotai
andselectedWorkspaceAtom
import from@/store
toapps/platform/src/components/dashboard/project/projectCard/index.tsx
. [1] [2]selectedWorkspace
atom value in theProjectCard
function.href
attribute.Updates to
Navbar
component:apps/platform/src/components/shared/navbar/index.tsx
.Mentions
@rajdip-b
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
Introduced workspace slug integration for project URLs.
Added new pages for managing environments, secrets, and variables.
Enhanced
ProjectCard
andNavbar
components for workspace-specific navigation.Implemented dynamic project and environment fetching with error handling.
Changes walkthrough 📝
page.tsx
Add environment management page
apps/platform/src/app/(main)/(project)/[workspace]/project/[project]/@environment/page.tsx
page.tsx
Add secret management page
apps/platform/src/app/(main)/(project)/[workspace]/project/[project]/@secret/page.tsx
page.tsx
Add variable management page
apps/platform/src/app/(main)/(project)/[workspace]/project/[project]/@variable/page.tsx
layout.tsx
Add layout for detailed project pages
apps/platform/src/app/(main)/(project)/[workspace]/project/[project]/layout.tsx
index.tsx
Update ProjectCard for workspace-specific navigation
apps/platform/src/components/dashboard/project/projectCard/index.tsx
selectedWorkspaceAtom
for workspace-specific navigation.index.tsx
Update Navbar for workspace-specific navigation
apps/platform/src/components/shared/navbar/index.tsx