feat(platform): Edit secret in your project

[poswalsameer]

User description

Description

This PR adds the feature of editing a secret in your project.

Mentions

@kriptonian1 @rajdip-b

Screenshots of relevant screens

edit-secret-keyshade.mp4

Developer's checklist

• My PR follows the style guidelines of this project
• I have performed a self-check on my work

If changes are made in the code:

• I have followed the coding guidelines
• My changes in code generate no new warnings
• My changes are breaking another fix/feature of the project
• I have added test cases to show that my feature works
• I have added relevant screenshots in my PR
• There are no UI/UX issues

Documentation Update

• This PR requires an update to the documentation at docs.keyshade.xyz
• I have made the necessary updates to the documentation, or no documentation changes are required.

---

PR Type

Enhancement, Bug fix

---

Description

• Added functionality to edit and delete secrets.

  • Integrated EditSecretSheet for editing secrets.
  • Added ConfirmDeleteSecret for deleting secrets with confirmation.

• Enhanced UI/UX with context menus and improved layouts.

  • Updated SecretCard to include context menu for edit/delete options.
  • Improved table and accordion styling for better readability.

• Fixed state management issues for selected secrets.

  • Reset selectedSecret after deletion to avoid stale state.

---

Changes walkthrough 📝

Relevant files

Enhancement

page.tsx Integrate edit and delete functionality in secret page      apps/platform/src/app/(main)/project/[project]/@secret/page.tsx Added EditSecretSheet and ConfirmDeleteSecret components. Integrated state management for editing and deleting secrets. Updated layout to handle inert state during delete confirmation. +39/-16  index.tsx Add delete confirmation dialog for secrets                              apps/platform/src/components/dashboard/secret/confirmDeleteSecret/index.tsx Added ConfirmDeleteSecret component for delete confirmation. Implemented toast notifications for success and error states. Managed state cleanup after dialog closure. +136/-0  index.tsx Add edit sheet for modifying secrets                                          apps/platform/src/components/dashboard/secret/editSecretSheet/index.tsx Added EditSecretSheet component for editing secrets. Implemented form handling for secret name and note updates. Added toast notifications for success and error states. +171/-0  index.tsx Enhance secret card with context menu and actions                apps/platform/src/components/dashboard/secret/secretCard/index.tsx Added context menu for edit and delete actions. Updated table and accordion styles for better UI. Integrated state management for selected secrets. +109/-72

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 Security concerns Sensitive information exposure: The secret values are displayed in plain text when decrypted (secretCard/index.tsx line 118). Consider masking sensitive values even when decrypted, or adding additional confirmation steps before showing decrypted values.

⚡ Recommended focus areas for review Input Validation The secret name and note fields lack proper input validation. Empty or invalid values could be submitted. onChange={(e) => { setRequestData((prev) => ({ ...prev, name: e.target.value })) }} value={requestData.name} State Management The component does not handle API errors gracefully - it closes the dialog even when deletion fails. handleClose() }, [setSecrets, selectedSecret, handleClose])

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	✅ Prevent empty secret name updates Add input validation to prevent empty secret names. The current code allows updating a secret with an empty name which could cause issues. apps/platform/src/components/dashboard/secret/editSecretSheet/index.tsx [51-59] const request: UpdateSecretRequest = { secretSlug: secret.slug, - name: - requestData.name === secret.name || requestData.name === '' - ? undefined - : requestData.name, - note: requestData.note === '' ? undefined : requestData.note, + name: + !requestData.name?.trim() || requestData.name === secret.name + ? undefined + : requestData.name.trim(), + note: requestData.note?.trim() || undefined, entries: undefined } [Suggestion has been applied] Suggestion importance[1-10]: 8 Why: The suggestion adds important validation to prevent empty secret names by properly trimming whitespace and handling undefined values. This helps maintain data integrity and prevents potential bugs.	8
	Prevent duplicate delete operations Add a loading state during secret deletion to prevent multiple delete requests and improve UX feedback. apps/platform/src/components/dashboard/secret/confirmDeleteSecret/index.tsx [33-44] +const [isDeleting, setIsDeleting] = useState(false) const deleteSecret = useCallback(async () => { + if (isDeleting) return if (selectedSecret === null) { toast.error('No secret selected', { description: ( <p className="text-xs text-red-300"> No secret selected. Please select a secret. </p> ) }) return } + setIsDeleting(true) + try { + // deletion logic + } finally { + setIsDeleting(false) + } Apply this suggestion Suggestion importance[1-10]: 7 Why: Adding a loading state during deletion prevents duplicate requests and improves user feedback, which is important for critical operations like deletion. This enhances both UX and prevents potential race conditions.	7

[Swastik19Nit]

@poswalsameer can you tell me how did you manage to get rid of cors issue.. i just did the same way as per doc but nestjs backend is not running

[poswalsameer]

@rajdip-b the tab size is 2 in my local. Nothing to commit from my side.

[rajdip-b]

Need to update the tab size of this file. I'll add this to my to-do

[rajdip-b]

There were a lot of linting errors in your code. Please make sure to double-check that before pushing the code.

[rajdip-b]

🎉 This PR is included in version 2.11.0-stage.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀