-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dockerize api #79
Conversation
PR Description updated to latest commit (6b756e8) |
PR Analysis(review updated until commit 265cec0)
PR Feedback💡 General suggestions: It's good to see that the applications are being dockerized, which will help in easier deployment and scaling. However, it would be beneficial to include tests to ensure the Dockerized applications work as expected. Also, consider removing the commented environment variables from the Dockerfile and manage them using Docker Compose or Kubernetes for better security and management. 🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, do add a .dockerignore
file in both web and api. for now just add node_modules
in that file. Later on, we can add more stuff when needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make the update to web.yaml
workflow, and this PR should be good to go!
/review |
Persistent review updated to latest commit 265cec0 |
Done 👍🏻 |
Made some changes to the final PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now!
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
apps/api
apps/web
as DockerfileFixes #29
Future Improvements
apps/web
as Dockerfile, some change are to be made on workflowsstart:api
should be added to package.jsonMentions
@rajdip-b
Developer's checklist
If changes are made in the code:
Documentation Update