Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for force_post to allow interception without evilginx session #1069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephenbradshaw
Copy link

This is a fix for an issue where EvilGinx will not do force_post replacement for requests to a phished domain if cookies (in particular the EvilGinx session cookie) are not included with the request. This is breaking proper interception of authentication flows where for example part of the process has a request made using JavaScript without adding cookies.

An example affected issue is here:

#1031

Have fixed by moving the existing force_post code into its own if branch that does not check for a evilginx session and adding a requirement for the request method to be "POST" - figured that since force_post has its own fairly specific conditions for matching requests that the session requirement can be overlooked

@n3rada
Copy link

n3rada commented Aug 26, 2024

It works like a charm with this. Let's go merging this @kgretzky.

@stephenbradshaw
Copy link
Author

I will point out here that responses to the POST don't get captured by EvilGinx if they happen to have any authentication tokens even with this fix because of the missing session cookie. So if thats important to you, you might need to instead do some modification of whatever client side JavaScript code is generating the POST to include cookies so that things work as expected with EvilGinx sessions.

@n3rada
Copy link

n3rada commented Aug 28, 2024

My use case was to modify one of the keys of an outgoing POST request. Thanks for mentioning it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants