Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CI failures #216

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Address CI failures #216

merged 3 commits into from
Dec 28, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Dec 23, 2024

  1. In the "pytest" workflow, TestISTAT.test_gh_104(): the query of https://esploradati.istat.it/SDMXWS/rest/data/22_289/.IT..1+2.TOTAL.99 is returning a 404 error with the text/plain content:

    Error while retrieving Mappings from "Mapping Store"! Cause:Dataflow 'urn:sdmx:org.sdmx.infomodel.datastructure.Dataflow=IT1:22_289(1.0)' doesn't contain a mapping set

    Despite the response code, this appears to be more of a 500 Internal Server Error → mark as Xfail

  2. In the "sources" CI workflow, the "collect" job was not correctly updated in Fix read of str:Categorisation > str:Target from SDMX-ML 2.1 #215 to use uv run python ….

PR checklist

  • Checks all ✅
  • Update documentation N/A, CI changes only
  • Update doc/whatsnew.rst

@khaeru khaeru added data-source Issues related to specific web services/data source(s) ci labels Dec 23, 2024
@khaeru khaeru self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (2accc1c) to head (b3a8e53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   98.03%   98.88%   +0.85%     
==========================================
  Files          98       98              
  Lines        8231     8232       +1     
==========================================
+ Hits         8069     8140      +71     
+ Misses        162       92      -70     
Files with missing lines Coverage Δ
sdmx/tests/test_sources.py 96.69% <100.00%> (+3.33%) ⬆️

... and 18 files with indirect coverage changes

- Use 'uv run --no-sync' to avoid changing installed packages.
@khaeru khaeru merged commit 9698161 into main Dec 28, 2024
20 checks passed
@khaeru khaeru deleted the fix/ci branch December 28, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci data-source Issues related to specific web services/data source(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant