objfw: move passthru test to its own file (NixOS#367625)

khaneliman · Dec 23, 2024 · 4751b20 · 4751b20
2 parents 5195fb3 + e8c6769
commit 4751b20
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 38 deletions.
diff --git a/pkgs/by-name/ob/objfw/package.nix b/pkgs/by-name/ob/objfw/package.nix
@@ -33,44 +33,7 @@ clangStdenv.mkDerivation (finalAttrs: {
   doCheck = true;
 
   passthru.tests = {
-    build-hello-world = clangStdenv.mkDerivation {
-      name = "ObjFW test";
-      buildInputs = [ objfw ];
-
-      src = writeTextDir "helloworld.m" ''
-        #import <ObjFW/ObjFW.h>
-        int main() {
-          OFLog(@"Hello world from objc");
-          return 0;
-        }
-      '';
-
-      buildPhase = ''
-        runHook preBuild
-        clang -o testbinary \
-              -x objective-c -Xclang \
-              -fobjc-runtime=objfw \
-              -funwind-tables \
-              -fconstant-string-class=OFConstantString \
-              -Xclang -fno-constant-cfstrings \
-              helloworld.m \
-              -lobjfw -lobjfwrt
-        runHook postBuild
-      '';
-
-      checkPhase = ''
-        runHook preCheck
-        ./testbinary
-        runHook postCheck
-      '';
-      doCheck = true;
-
-      installPhase = ''
-        runHook preInstall
-        touch $out
-        runHook postInstall
-      '';
-    };
+    build-hello-world = (import ./test-build-and-run.nix) { inherit clangStdenv objfw writeTextDir; };
   };
 
   meta = {

diff --git a/pkgs/by-name/ob/objfw/test-build-and-run.nix b/pkgs/by-name/ob/objfw/test-build-and-run.nix
@@ -0,0 +1,44 @@
+{
+  clangStdenv,
+  objfw,
+  writeTextDir,
+}:
+
+clangStdenv.mkDerivation {
+  name = "ObjFW test";
+  buildInputs = [ objfw ];
+
+  src = writeTextDir "helloworld.m" ''
+    #import <ObjFW/ObjFW.h>
+    int main() {
+        OFLog(@"Hello world from objc");
+        return 0;
+    }
+  '';
+
+  buildPhase = ''
+    runHook preBuild
+    clang -o testbinary \
+            -x objective-c -Xclang \
+            -fobjc-runtime=objfw \
+            -funwind-tables \
+            -fconstant-string-class=OFConstantString \
+            -Xclang -fno-constant-cfstrings \
+            helloworld.m \
+            -lobjfw -lobjfwrt
+    runHook postBuild
+  '';
+
+  checkPhase = ''
+    runHook preCheck
+    ./testbinary
+    runHook postCheck
+  '';
+  doCheck = true;
+
+  installPhase = ''
+    runHook preInstall
+    touch $out
+    runHook postInstall
+  '';
+}